From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18712 invoked by alias); 29 Apr 2009 08:54:02 -0000 Received: (qmail 18701 invoked by uid 22791); 29 Apr 2009 08:54:01 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 08:53:53 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 4827429006B; Wed, 29 Apr 2009 10:53:51 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P2F4TI248-eD; Wed, 29 Apr 2009 10:53:50 +0200 (CEST) Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) by mel.act-europe.fr (Postfix) with ESMTP id 23D93290066; Wed, 29 Apr 2009 10:53:50 +0200 (CEST) Received: by province.act-europe.fr (Postfix, from userid 560) id 1C6931661D9; Wed, 29 Apr 2009 10:53:50 +0200 (CEST) Date: Wed, 29 Apr 2009 08:54:00 -0000 From: Jerome Guitton To: Joel Brobecker Cc: gdb-patches@sources.redhat.com, Francois Rigault Subject: Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab Message-ID: <20090429085350.GW37172@adacore.com> References: <20090114174542.GM84382@adacore.com> <20090115094511.GB80710@adacore.com> <20090428195726.GA31821@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090428195726.GA31821@adacore.com> User-Agent: Mutt/1.5.17 (2007-11-01) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00785.txt.bz2 Joel Brobecker (brobecker@adacore.com): > > > 2009-01-14 Jerome Guitton > > > > > > * symtab.c (lookup_partial_symtab): When looking up an absolute path > > > in the partial symtabs, compare the base names before checking the > > > full names. > > We're only 3.5 months late reviewing this patch :-(... This looks OK > to me. I verified that this cannot create behavior changes due to > find_and_open_source returning a fullname with a different basename > (for instance if the source file was actually a link to another source > file): openp only canonicalizes the directory portion of the fullname. > > So I think this is reasonable. Please go ahead and commit. There has been an alternative patch for the same problem, submitted here: http://sourceware.org/ml/gdb-patches/2009-03/msg00309.html François' patch should handle one more problem (files can be the same even if basenames differs). So I prefer his approach. I think there's still some paperwork to be done before we can merge his changes into GDB (copyright assignment), but I guess that it will happen at some point in the future. If not, I will modify my patch to take the link problem into account.