From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31683 invoked by alias); 29 Apr 2009 04:05:21 -0000 Received: (qmail 31674 invoked by uid 22791); 29 Apr 2009 04:05:19 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 04:05:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 655EE2BAB74; Wed, 29 Apr 2009 00:05:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MjTxHD7gDTiZ; Wed, 29 Apr 2009 00:05:12 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 272FD2BAB20; Wed, 29 Apr 2009 00:05:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 55049F5924; Tue, 28 Apr 2009 21:05:06 -0700 (PDT) Date: Wed, 29 Apr 2009 04:05:00 -0000 From: Joel Brobecker To: S?rgio Durigan J?nior Cc: luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers Message-ID: <20090429040506.GI31821@adacore.com> References: <1223404355.7030.20.camel@miki> <1224184035.27672.64.camel@miki> <1231289020.2026.3.camel@miki> <200901070955.n079twBj014790@brahms.sibelius.xs4all.nl> <1231344540.2026.7.camel@miki> <1231436749.2026.19.camel@miki> <1231503988.12849.6.camel@gargoyle> <1232558849.6328.23.camel@miki> <20090428200725.GC31821@adacore.com> <1240953172.2392.1.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240953172.2392.1.camel@miki> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00779.txt.bz2 > > Sorry for the delay in reviewing this. I don't know much about ptrace > > except as a user, but this seems to make sense. The only request I have > > is for you to write a small comment describing each new function you > > introduce. The patch is OK with those changes. > > So the request is about the ChangeLog, right? Ok, I'll resubmit it with > the modifications as soon as possible. Actually, no. The comments are for the functions themselves. We're trying to make sure that every new function gets in with some documentation of what it does. It doesn't have to be very long, but sometimes writing what the return value is about is very useful. For instance, I remember that some of your functions will return zero if the operation failed, I think. That's an interesting piece of information to put in the documentation. When the function is obvious, or when it implements a routine that's part of the gdbarch vector, then what we've been doing, lately, is just say "Implements the "bla_bla_bla" gdbarch method." or somesuch (we try not to repeat the documentation to avoid maintenance issues). -- Joel