From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27311 invoked by alias); 28 Apr 2009 21:55:40 -0000 Received: (qmail 27285 invoked by uid 22791); 28 Apr 2009 21:55:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Apr 2009 21:55:33 +0000 Received: (qmail 6790 invoked from network); 28 Apr 2009 21:55:31 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Apr 2009 21:55:31 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Submit process record and replay fourth time, 3/8 Date: Tue, 28 Apr 2009 21:55:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu , Michael Snyder References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904282255.35290.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00772.txt.bz2 On Tuesday 28 April 2009 11:12:03, Hui Zhu wrote: > 2009-03-21 Hui Zhu > > Process record and replay target. > > * Makefile.in (record.c): New file. > * record.c, record.h: New file. > > 2008-12-28 Michael Snyder > * Comments, spelling, white space clean-ups. > > 2008-12-26 Michael Snyder > * record.h: Don't export record_not_record. > * record.c (record_not_record): Rename to in_record_wait. > (record_not_record_set): Rename to in_record_wait_set. > (record_not_record_cleanup): Rename to in_record_wait_cleanup. > (record_store_registers): Check in_record_wait flag. > (record_xfer_partial): Ditto. > ... Sorry that I have to be the nick-picky-guy again, but, as far as I know and can see, we don't use that style of change log entry covering the history of the changes that led to the current form of the patch. I know I've seen it before in *branches*, but never on mainline's ChangeLog file. The standard form of entry when more than one person did work on a patch, is to append the name of the person in the header, like so: 2009-03-21 Hui Zhu Michael Snyder * Makefile.in (SFILES): Add record.c. (COMMON_OBS): Add record.o. * record.c, record.h: New files. You'll find plenty examples of entries like that in the ChangeLog files. Would you mind making that change? Thanks in advance. BTW, notice that I've tweaked the Makefile.in entry a bit, to more accurately describe the change being made. -- Pedro Alves