From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28162 invoked by alias); 28 Apr 2009 13:09:21 -0000 Received: (qmail 28152 invoked by uid 22791); 28 Apr 2009 13:09:21 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Apr 2009 13:09:16 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E1ECE10555; Tue, 28 Apr 2009 13:09:13 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id ACDB910554; Tue, 28 Apr 2009 13:09:13 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Lyn3g-0002E9-1P; Tue, 28 Apr 2009 09:09:12 -0400 Date: Tue, 28 Apr 2009 13:09:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: 'Tom Tromey' , 'Joel Brobecker' , gdb-patches@sourceware.org Subject: Re: [RFC] Change OK: to ARI: for ARI rule ignore Message-ID: <20090428130911.GA8177@caradoc.them.org> Mail-Followup-To: Pierre Muller , 'Tom Tromey' , 'Joel Brobecker' , gdb-patches@sourceware.org References: <001901c9c399$81854fe0$848fefa0$@u-strasbg.fr> <002a01c9c3df$d77f5760$867e0620$@u-strasbg.fr> <007501c9c533$d0a9c240$71fd46c0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <007501c9c533$d0a9c240$71fd46c0$@u-strasbg.fr> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00755.txt.bz2 I have no comments on your change, but I do have a request: On Sat, Apr 25, 2009 at 01:24:27AM +0200, Pierre Muller wrote: > $ cvs diff gdb_ari.sh > Index: gdb_ari.sh > =================================================================== > RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v > retrieving revision 1.89 > diff -r1.89 gdb_ari.sh > 149a150,152 > > if (ARI_OK == bug) { > > return > > } My ~/.cvsrc contains "diff -upN". It does not really matter what the options are - but please use either unified (my preference for most changes) or context diff. Classic diff is too hard to read. -- Daniel Jacobowitz CodeSourcery