From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63351-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21641 invoked by alias); 27 Apr 2009 22:20:22 -0000
Received: (qmail 21633 invoked by uid 22791); 27 Apr 2009 22:20:21 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Apr 2009 22:20:16 +0000
Received: (qmail 7323 invoked from network); 27 Apr 2009 22:20:14 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 27 Apr 2009 22:20:14 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Subject: Re: [RFA] Submit process record and replay fourth time, 4/8
Date: Mon, 27 Apr 2009 22:20:00 -0000
User-Agent: KMail/1.9.10
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Marc Khouzam <marc.khouzam@ericsson.com>,  Michael Snyder <msnyder@vmware.com>,  Thiago Jung Bauermann <bauerman@br.ibm.com>,  Eli Zaretskii <eliz@gnu.org>,  paawan1982@yahoo.com
References: <daef60380903210901l16f32f61p62fb3a9236772d03@mail.gmail.com> <daef60380904220206j407f21dcl670b4ad5e43ebea1@mail.gmail.com>
In-Reply-To: <daef60380904220206j407f21dcl670b4ad5e43ebea1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200904272320.13698.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00745.txt.bz2

Hi Hui,

Let's just fix a few small issues, and then put this in.

(There are more issues here to solve here --- e.g., IIRC, Marc reported
success in using precord against gdbserver (that was only made possible
due to the fact that we managed to remove everything there used to=20
be in linux-nat.c in previous versions and move those things to record.c),
but, it will only work when debugging from a x86-linux host,
cross debugging will not work correctly.  But, this is a minor thing
to handle at this point.)

On Wednesday 22 April 2009 10:06:42, Hui Zhu wrote:
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0if (record_debug)
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0fprintf_unfilte=
red (gdb_stdlog,
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0"Process record: error rea=
ding "
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0"memory at addr =3D 0x%s l=
en =3D %d.\n",
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0paddr_nz (tmpu32), sizeof =
(a));
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0return -1;


Printing `sizeof(foo)' with a %d formatter will fail to compile due
to a warning on 64-bit hosts, yet you've added linux-record.o to
the x86_64-*-linux* configuration.   Please fix that before checking in.
You have more instances of this in the patch.

On Wednesday 22 April 2009 10:06:42, Hui Zhu wrote:
> +   Copyright (C) 2008 Free Software Foundation, Inc.

2009.

+typedef struct linux_record_tdep_s
+{
...
+ } linux_record_tdep_t;

As in other parts of the series, this 'typedef struct foo_s foo_t'
doesn't fit GDB's style.  Just make this 'struct linux_record_tdep'
instead.

This patch is approved with the above fixes, and a changelog entry.

--=20
Pedro Alves