From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29044 invoked by alias); 24 Apr 2009 00:01:01 -0000 Received: (qmail 29029 invoked by uid 22791); 24 Apr 2009 00:01:00 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 00:00:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A08782BABC1; Thu, 23 Apr 2009 20:00:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A04nE5awtGWY; Thu, 23 Apr 2009 20:00:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6D9812BAB6E; Thu, 23 Apr 2009 20:00:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9E7D6F5924; Thu, 23 Apr 2009 17:00:50 -0700 (PDT) Date: Fri, 24 Apr 2009 00:01:00 -0000 From: Joel Brobecker To: Anthony Green Cc: gdb-patches@sourceware.org Subject: Re: PATCH: new gdb port: moxie-elf Message-ID: <20090424000050.GK7552@adacore.com> References: <20090423045725.aaa2c6acbe2fcbd4897bea2c255aade5.61d9530215.wbe@email03.secureserver.net> <20090423182851.GC7552@adacore.com> <49F0FC8C.4010204@moxielogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49F0FC8C.4010204@moxielogic.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00680.txt.bz2 > 2009-04-23 Anthony Green > * moxie-tdep.h: New file. > * moxie-tdep.c: New file. > * configure.tgt: Add moxie-elf. Looks good to me, after you fix the minor style issues reported below. Can you also send a patch announcing this new port in the NEWS file? You probably also need to update the MAINTAINERS file in the "Target Instruction Set Architectures" section to add your architecture to the list. That way, gdb_buildall.sh will pick it up. This target compiles with -Werror, right? > +static CORE_ADDR > +moxie_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) I see that you decided to keep this function implementation as is. As long as it works for you, that's fine. I would be a little more concerned if this had any repercussions on the core-gdb maintainance, but I don't see this as being a potential problem. > + /* No function symbol -- just return the PC. */ Just an extra space missing here. > +/* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy > + frame. The frame ID's base needs to match the TOS value saved by > + save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint. */ This function description should be removed. > +/* moxie register names. */ Missing extra space :) -- Joel