Re: [PATCH/Obvious] Fix error in last ARI fix for gnu-nat.h

Pedro Alves
2009-04-22T18:45:01Z

On Tuesday 21 April 2009 12:26:50, Pierre Muller wrote:
> I missed to add a continuation line in the proc_debug macro in gnu-nat.h
>
> Committed as obvious fix.
>
> I discovered this while looking at the
> THREAD_STATE_* macros (listed in ARI).
>

> These macros are all defined only once in
> config/i386/nm-i386gnu.h
> and used only in gnu-nat.c source
> unconditionally. This probably means that gnu hurd can only
> be compiled for i386 processor anyhow...

Right, but the way the code is layed out, it should be easy to
add support for other processors, in case the Hurd is ported
(I'm not sure what archs the Hurd runs on).

> Which in turn, means that we could probably move the stuff
> from gnu-nat.c to i386gnu-nat.c

I'm not exactly sure what you're proposing here. It looks
like you'd have to move pieces of generic gnu/Hurd code
over to i386gnu-nat.c as well. Keep in mind that macros
afecting the native target only in nm.h files aren't a
big a deal. GDB can't be compiled for more than one
native target anyway.

> I can send a patch for this, but
> I will not be able to test compilation,
> as this would require access to gnu HURD.

I can do that for you, no problem. I've got a debian/Hurd
vmware image here.

If you want to set one up yourself, it's easy --- you'll find
prebuilt debian/Hurd vmware images on the web ready to go.
Being debian, it doesn't feel *that* much different.

--
Pedro Alves