From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27521 invoked by alias); 22 Apr 2009 17:57:05 -0000 Received: (qmail 27509 invoked by uid 22791); 22 Apr 2009 17:57:03 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 17:56:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7738C2BABE2; Wed, 22 Apr 2009 13:56:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jK3-tgDmuGEh; Wed, 22 Apr 2009 13:56:55 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EECCA2BABAF; Wed, 22 Apr 2009 13:56:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 19015F5886; Wed, 22 Apr 2009 10:56:43 -0700 (PDT) Date: Wed, 22 Apr 2009 17:57:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] gdbadmin/ss/gdb_find.sh cleanup Message-ID: <20090422175643.GA22514@adacore.com> References: <000b01c9c31d$d0ecfd70$72c6f850$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000b01c9c31d$d0ecfd70$72c6f850$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00600.txt.bz2 > -name signals -prune -o \ I can't find a "signals" directory. Can you double-check and remove this line if I'm right? (if it makes sense to you too) > -name testsuite -prune -o \ > -name gdbserver -prune -o \ I wonder if we want to start tracking the gdbserver sources as well. Just a thought... > -name gnulib -prune -o \ > -name rdi-share -prune -o \ Can't find this directory either... > -name remote-mips.c -prune -o \ This file started being excluded in Jan 2005. There's definitely been some activity on the associated target, so I'm thinking it might make sense to stop excluding it. > 'sh64*' and 'remote-mips.c' > sh64* covers > gdb/sh64-tdep.c file > and > config/sh64 directory. Strange, I can't find that config/sh64 directory either. > Why are those patterns excluded? Here what the CVS log says about the change that introduced the exclusion: revision 1.7 date: 2004/08/03 13:09:19; author: cagney; state: Exp; lines: +9 -2 Ignore (hardwired) broken targets. Since then, it appears that Corinna Vinshen has done some work to revive the target. So we might again want to remove them from the exclusion list. To be checked with Corinna? > < -name ada-lex.c -prune -o \ DanielJ specifically removed this file from the list. I'm not sure whether anything changed that would make us change our decision. This is a generated file - perhaps we should check the source .l file instead (which I think we do). > < -name cp-name-parser.c -prune -o \ Same here. This is a generated file. > < -name stop-gdb.c -prune -o \ > 19,21d15 > < -name lynx-nat.c -prune -o \ > < -name ppc-bdm.c -prune -o \ > < -name ppc-bdm.c -prune -o \ > 23,24d16 > < -name remote-sds.c -prune -o \ > < -name remote-sds.c -prune -o \ The rest seems OK to me. -- Joel