Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, Thiago Jung Bauermann <bauerman@br.ibm.com>,
		gdb-patches ml <gdb-patches@sourceware.org>,
		Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][rfc] Allow GDB to search for the right 	libthread_db.so.1
Date: Wed, 22 Apr 2009 17:25:00 -0000	[thread overview]
Message-ID: <20090422172517.GA17235@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0904201208m95d4585k2b09f6b6fe5edb40@mail.gmail.com>

On Mon, Apr 20, 2009 at 12:08:54PM -0700, Paul Pluzhnikov wrote:
> Previously, dlopen was performed at initialization time, and then
> thread_db_ops was pushed when (and only when) td_ta_new returned TD_OK
> (checked on attach, and on every new solib).
> 
> If td_ta_new returned TD_NOLIBTHREAD, we assumed that there are no threads
> at all (at least not yet), and any other error produced a warning.
> 
> One example where this fails: static LinuxThreads exe on NPTL system:
> td_ta_new returns TD_NOLIBTHREAD (which is semi-correct -- no NPTL
> libpthread), so no warning is issued; but then GDB doesn't work :-(
> 
> The symbol lookup is there in the new code to firmly establish a point
> where threads are known to be present, so we can issue correct warning if
> at that point no working libthread_db can be found.

... if we have symbols.

> I don't see how to establish that "threads are present" point without
> symbol lookup, nor how to keep the proper warning if we don't know for
> sure whether they are.

If you want to generate a warning when there are threads - not just
threads, but also a thread library - and no matching libthread_db,
then I suppose this is the only way.

Personally, I'd rather ditch the warning for static binaries.  Check
the shared library list for libpthread if all available libthread_db's
have failed, and if there is one, warn then.  Any thoughts on that?

Otherwise, I won't object to what you've got.  I am just generally
dissatisfied with hard-coding a list of symbols from the
implementation.  e.g. uClibc could legitimately use different names.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-04-22 17:25 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 20:39 Paul Pluzhnikov
2009-04-08 21:23 ` Thiago Jung Bauermann
2009-04-10 19:06   ` Paul Pluzhnikov
2009-04-16 17:56     ` Tom Tromey
2009-04-16 18:22       ` Eli Zaretskii
2009-04-17 19:13       ` Paul Pluzhnikov
2009-04-18 17:01         ` Eli Zaretskii
2009-04-19 14:59         ` Thiago Jung Bauermann
2009-04-19 18:03           ` Paul Pluzhnikov
2009-04-20 13:18         ` Daniel Jacobowitz
2009-04-20 16:47           ` Paul Pluzhnikov
2009-04-20 17:02             ` Daniel Jacobowitz
2009-04-20 17:20               ` Paul Pluzhnikov
2009-04-20 18:04                 ` Daniel Jacobowitz
2009-04-20 19:09                   ` Paul Pluzhnikov
2009-04-22 17:25                     ` Daniel Jacobowitz [this message]
2009-04-23  1:10                       ` Paul Pluzhnikov
2009-04-23  1:34                         ` Tom Tromey
2009-04-23  6:28                           ` Hui Zhu
2009-04-23  6:21                         ` Hui Zhu
2009-04-23  7:01                           ` Paul Pluzhnikov
2009-04-23  8:06                             ` Hui Zhu
2009-04-23 11:32                               ` Hui Zhu
2009-04-29 20:30                                 ` Paul Pluzhnikov
2009-04-30  5:38                                   ` Hui Zhu
2009-04-30 18:56                                   ` Joel Brobecker
2009-04-30 19:11                                     ` Paul Pluzhnikov
2009-04-30 22:12                                       ` Doug Evans
2009-04-30 23:18                                       ` Paul Pluzhnikov
2009-05-01  0:20                                         ` Paul Pluzhnikov
2009-05-11 13:13                                           ` Pedro Alves
2009-05-11 18:09                                             ` Paul Pluzhnikov
2009-05-11 21:09                                               ` Pedro Alves
2009-05-12  7:16                                               ` Hui Zhu
2009-05-12 16:42                                                 ` Paul Pluzhnikov
2009-05-13  2:56                                                   ` Hui Zhu
2009-05-13  3:29                                                     ` Paul Pluzhnikov
2009-05-13  4:39                                                       ` Hui Zhu
2009-05-15 14:37                                               ` Daniel Jacobowitz
2009-05-15 16:56                                                 ` Paul Pluzhnikov
2009-05-01  7:21                                         ` Eli Zaretskii
2009-05-01 15:49                                           ` Paul Pluzhnikov
2009-05-01 16:49                                             ` Daniel Jacobowitz
2009-05-01 17:02                                               ` Paul Pluzhnikov
2009-05-01 17:11                                                 ` Daniel Jacobowitz
2009-05-01 17:17                                                 ` Pedro Alves
2009-05-01 18:53                                                   ` Doug Evans
2009-05-04  0:07                                     ` Hui Zhu
2009-05-04  3:31                                       ` Paul Pluzhnikov
2009-05-05  2:54                                         ` Hui Zhu
2009-05-05  3:38                                           ` Joel Brobecker
2009-05-05 11:42                                             ` Hui Zhu
2009-05-11 11:34                                               ` Pedro Alves
2009-05-11 12:24                                                 ` Joel Brobecker
2009-04-20 17:37             ` Paul Pluzhnikov
2009-04-20 18:46               ` Eli Zaretskii
2015-08-25 18:01 ` Jan Kratochvil
2015-08-25 18:14   ` Paul Pluzhnikov
2015-08-25 18:22     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422172517.GA17235@caradoc.them.org \
    --to=drow@false.org \
    --cc=bauerman@br.ibm.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox