From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63037-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8680 invoked by alias); 17 Apr 2009 13:59:38 -0000
Received: (qmail 8561 invoked by uid 22791); 17 Apr 2009 13:59:37 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 	tests=AWL,BAYES_00,SARE_SUB_PCT_LETTER,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Apr 2009 13:59:29 +0000
Received: (qmail 30692 invoked from network); 17 Apr 2009 13:59:27 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 17 Apr 2009 13:59:27 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: %p rule
Date: Fri, 17 Apr 2009 13:59:00 -0000
User-Agent: KMail/1.9.10
Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>
References: <000601c9bf26$50f53740$f2dfa5c0$@u-strasbg.fr>
In-Reply-To: <000601c9bf26$50f53740$f2dfa5c0$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200904171459.39219.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00431.txt.bz2

On Friday 17 April 2009 07:32:43, Pierre Muller wrote:
> Most of the remaining usages of %p
> in printf family messages
> are related to pointers in the host space
> rater that target space.
>=20
> =A0 Thus the recommendation to use paddress
> is not correct for these cases, and I=20
> used host_address_to_string instead.
>=20
> Is this OK?

Looks okay.  Thanks.

(I have a sekret itch that keeps telling me that
host_address_to_string is such a long name for this)

> Pierre Muller
> Pascal language support maintainer for GDB
>=20
> I left a few cases out, where
> the %p value was not a simple pointer
> but a arithmetic operation,
> I don't know the rules for C,
> is an addition of a pointer and a integer
> always of type pointer?
>=20
> 2009-04-17 =A0Pierre Muller =A0<muller.u-strasbg.fr>
>=20
> =A0=A0=A0=A0=A0=A0=A0=A0ARI fix: Do not use %p, replace by call to host_a=
ddress_to_string
> =A0=A0=A0=A0=A0=A0=A0=A0for host pointers.
> =A0=A0=A0=A0=A0=A0=A0=A0* darwin-nat.c (darwin_xfer_partial): Apply chang=
e.
> =A0=A0=A0=A0=A0=A0=A0=A0* gnu-nat.c (inf_continue, gnu_xfer_memory): Ditt=
o.
> =A0=A0=A0=A0=A0=A0=A0=A0* gnu-nat.h (proc_debug): Ditto.
> =A0=A0=A0=A0=A0=A0=A0=A0* symmisc.c (maintenance_info_symtabs): Ditto.
> =A0=A0=A0=A0=A0=A0=A0=A0(maintenance_info_psymtabs): Ditto.
> =A0=A0=A0=A0=A0=A0=A0=A0* windows-nat.c (handle_load_dll): Ditto.
> =A0=A0=A0=A0=A0=A0=A0=A0(handle_unload_dll, info_w32_command, handle_exce=
ption): Ditto.
> =A0=A0=A0=A0=A0=A0=A0=A0* xtensa-tdep.c (xtensa_unwind_pc): Ditto.
>=20

--=20
Pedro Alves