Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb_ari.sh cleanup
Date: Fri, 17 Apr 2009 00:19:00 -0000	[thread overview]
Message-ID: <20090417001923.GQ7585@adacore.com> (raw)
In-Reply-To: <001f01c9beec$934dd280$b9e97780$@u-strasbg.fr>

> I did not handle two macros, because
> they are unused but are still present in docs:
> REGISTER_U_ADDR
> PROCESS_LINENUMBER_HOOK

Let's just remove them from the documentation. It's a very simple
change, but let me know if you'd like me to take care of it.

> Miscellaneous questions:
> 1a) Should the PARAMS rule be moved to code section?
> 1b) Same question for __FUNCTION__ rule.
> 1c) Idem for ARGSUSED

Does it really make a difference? If it helps you analyze the results,
then I'd say go for it.

> 1d) Idem for

(name missing?)

> 2) LITTLE_ENDIAN and BIG_ENDIAN still exists in configure,
> should I still remove the rule?

I don't think so. I don't know what the details are, but I'm wondering
whether the macros might be defined by the compiler, thus making it
possible for us to accidently reintroduce this usage again.  I'd say,
let's keep the rule.

> 3) HAVE_VFORK is still present in config.in
> should I keep the rule or should we remove it from config.in first?

We need to keep the rule. That macro is still used by gdb_vfork.h
and it is a valid use of that macro. In a way, this is very similar
to the use of "abort" - only very selected uses are allowed.

-- 
Joel


  reply	other threads:[~2009-04-17  0:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 23:39 Pierre Muller
2009-04-17  0:19 ` Joel Brobecker [this message]
2009-04-17  6:39   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090417001923.GQ7585@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox