Re: [RFA] print error message if (auto) disassembly failed

Hui Zhu
2009-04-17T07:33:23Z

I try it in x86-linux with simple inferior and core file.
This patch works very well.

Thanks,
Hui

On Fri, Apr 17, 2009 at 07:57, Joel Brobecker <brobecker@adacore.com> wrote:
>> OK, but your suggested message text is too long, I think.  Something
>> shorter, like "(address unreadable)" is better, IMO.
>
> Frankly, I think this is overkill - even with the 64bit addresses
> the line was still less than 70 characters long. But I'm not going
> to argue. Here you go:
>
>    (gdb) core core
>    warning: core file may not match specified executable file.
>    Core was generated by `./crash'.
>    Program terminated with signal 6, Aborted.
>    #0  0x00007fe6fe543307 in ?? ()
>    0x00007fe6fe543307:     (cannot read memory)
>
> 2009-04-17  Joel Brobecker  <brobecker@adacore.com>
>
>        * stack.c (do_gdb_disassembly): Print an error message if an error
>        was thrown while trying to perform the disassembly.
>
> I'm currently testing this patch on x86_64-linux, but I don't really
> expect any problem.
>
> --
> Joel
>