From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6783 invoked by alias); 15 Apr 2009 14:00:53 -0000 Received: (qmail 6749 invoked by uid 22791); 15 Apr 2009 14:00:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Apr 2009 14:00:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id n3FE0fnm026844; Wed, 15 Apr 2009 14:00:41 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3FE0fX44014290; Wed, 15 Apr 2009 16:00:41 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3FE0e2M003127; Wed, 15 Apr 2009 16:00:41 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n3FE0div003099; Wed, 15 Apr 2009 16:00:39 +0200 Message-Id: <200904151400.n3FE0div003099@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 15 Apr 2009 16:00:39 +0200 Subject: Re: [RFC] GDB ARIndex Linux rule cleanup To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Wed, 15 Apr 2009 14:00:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com ('Joel Brobecker'), gdb-patches@sourceware.org, gdb@sourceware.org, eliz@gnu.org ('Eli Zaretskii') In-Reply-To: <007301c9bd55$a66e8320$f34b8960$@u-strasbg.fr> from "Pierre Muller" at Apr 15, 2009 01:06:30 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00302.txt.bz2 Pierre Muller wrote: > Index: ppc-linux-tdep.c > =================================================================== > -/* Wrappers to handle Linux-only registers. */ > +/* Wrappers to handle Linux-only kernel registers. */ > - /* Initialize the Linux target descriptions. */ > + /* Initialize the Linux kernel target descriptions. */ > Index: ppc-linux-tdep.h > =================================================================== > -/* Linux target descriptions. */ > +/* Linux kernel target descriptions. */ It seems to me that in *those* cases, we should actually use GNU/Linux instead -- this is talking about GDB target support for the GNU/Linux operating system on PowerPC, and not specifically related to the kernel only (for example, those target descriptions are also used when analysing a core file on a remote system). Compare for example the usage in linux-nat.c: /* Create a prototype generic GNU/Linux target. The other instances in your patch, where a kernel version is specifically named, clearly refer to the Linux kernel. I'd be fine with adding "kernel" to the text here; but I also agree with Eli's suggestion that it might be even better to have the ARI script recognize use of a version number ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com