From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20417 invoked by alias); 14 Apr 2009 18:56:16 -0000 Received: (qmail 20408 invoked by uid 22791); 14 Apr 2009 18:56:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Apr 2009 18:56:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DCDE92BAB82; Tue, 14 Apr 2009 14:56:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nXYv+dvThaRW; Tue, 14 Apr 2009 14:56:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AB3E12BAB34; Tue, 14 Apr 2009 14:56:09 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BA495F5A14; Tue, 14 Apr 2009 11:56:07 -0700 (PDT) Date: Tue, 14 Apr 2009 18:56:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [RFA] Ada ARI fix for sprintf version 2 Message-ID: <20090414185607.GQ7535@adacore.com> References: <000401c9b758$2c1cf4b0$8456de10$@u-strasbg.fr> <200904111620.17103.pedro@codesourcery.com> <20090414182432.GP7535@adacore.com> <006e01c9bd30$49a0bac0$dce23040$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006e01c9bd30$49a0bac0$dce23040$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00276.txt.bz2 > 2009-04-14 Pierre Muller > > ARI fix: sprintf rule. > * ada-exp.y (convert_char_literal): Replace sprintf by xsnprintf. > * ada-lang.c (add_angle_brackets): Use xstrprintf. > (ada_decode): Replace sprintf by xsnprintf. > (find_old_style_renaming_symbol): Ditto. > (ada_to_fixed_type_1, ada_enum_name): Ditto. Yes, this looks fine to me. Thanks for doing this. -- Joel