From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31696 invoked by alias); 11 Apr 2009 18:15:25 -0000 Received: (qmail 31687 invoked by uid 22791); 11 Apr 2009 18:15:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Apr 2009 18:15:16 +0000 Received: (qmail 18774 invoked from network); 11 Apr 2009 18:15:14 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Apr 2009 18:15:14 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [commit] Fix prototype related breakage in go32-nat.c Date: Sat, 11 Apr 2009 18:15:00 -0000 User-Agent: KMail/1.9.10 References: <834owvoyvb.fsf@gnu.org> In-Reply-To: <834owvoyvb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904111916.10115.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00214.txt.bz2 On Saturday 11 April 2009 18:59:20, Eli Zaretskii write: > Didn't we agree at the time that the prototypes should be corrected as > well? You're probably confused... those functions were changed much prior to that agreement: http://sourceware.org/ml/gdb-patches/2008-08/msg00403.html http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/go32-nat.c.diff?r1=1.60&r2=1.61&cvsroot=src&f=h Obviously, it was a simple lapse, one that wouldn't happen if these functions weren't needlessly forward declared. (and we agreed to *keep* the prototypes. Obviously, if they are to keep, they need to be adjusted, there's no need to agree on that) > Committed. > > > 2009-04-11 Eli Zaretskii > > * go32-nat.c (go32_attach, go32_detach:) Fix prototypes to be ^ Typo. > consistent with the change from 2009-03-17. ^^^^^^^^^^ Not that it matter a thing, but, ... wrong date, the change of the 17th only concerned target_kill. > > Index: gdb/go32-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/go32-nat.c,v > retrieving revision 1.67 > diff -u -r1.67 go32-nat.c > --- gdb/go32-nat.c 17 Mar 2009 19:28:08 -0000 1.67 > +++ gdb/go32-nat.c 11 Apr 2009 17:55:06 -0000 > @@ -167,8 +167,8 @@ > static int prog_has_started = 0; > static void go32_open (char *name, int from_tty); > static void go32_close (int quitting); > -static void go32_attach (char *args, int from_tty); > -static void go32_detach (char *args, int from_tty); > +static void go32_attach (struct target_ops *ops, char *args, int from_tty); > +static void go32_detach (struct target_ops *ops, char *args, int from_tty); > static void go32_resume (struct target_ops *ops, > ptid_t ptid, int step, > enum target_signal siggnal); > -- Pedro Alves