Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] release handle on object files after program exits
Date: Wed, 08 Apr 2009 23:12:00 -0000	[thread overview]
Message-ID: <200904090012.36584.pedro@codesourcery.com> (raw)
In-Reply-To: <20090408223829.GI7535@adacore.com>

On Wednesday 08 April 2009 23:38:29, Joel Brobecker wrote:
> Looks like generic_mourn_inferior is not necessarily called at
> the end of the execution of the program. Lots of targets actually
> call it at the end of their own mourn_inferior, but it is conceivable
> that some may not.

Hmmmm, all process_stratum targets do, but yes, I can imagine
a target not calling it.  We might have one internally --- remote
targets where a "process exit" is just an event and still leaves
execution in the target.  Oh, and when debugging multi-forks in linux,
and one of the forks exits, we skip the normal mourning tail end.  (Gosh,
how the checkpoints support is in the way for multiprocess...)  Not
that that matters much for Windows though.

> But you do have a point.  How about the following patch instead?
> Instead of closing all descriptors before calling the mourn_inferior
> routine, it does it after.

Looks fine to me.  Thanks!

-- 
Pedro Alves


  reply	other threads:[~2009-04-08 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 16:44 Joel Brobecker
2009-04-03 18:41 ` Tom Tromey
2009-04-08 16:48   ` Joel Brobecker
2009-04-08 17:14     ` Pedro Alves
2009-04-08 22:51       ` Joel Brobecker
2009-04-08 23:12         ` Pedro Alves [this message]
2009-04-14 16:51         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904090012.36584.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox