Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org, drow@false.org, dje@google.com
Subject: Re: [rfa/gdbserver] Updated: Fix crash in thread_db_get_tls_address
Date: Fri, 03 Apr 2009 19:20:00 -0000	[thread overview]
Message-ID: <200904031920.n33JK9Mn029781@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200904031926.56114.pedro@codesourcery.com> from "Pedro Alves" at Apr 03, 2009 07:26:55 PM

Pedro Alves wrote:

> The qGetTLSAddr packet takes an explicit thread id, so in this
> case, it may be that the current process isn't the
> correct one.  I think in this case the best would be to
> inferior.c:get_thread_process and use that, like:
> 
>   if (!get_thread_process (thread)->all_symbols_looked_up)
>     return TD_ERR;

That function is currently static to inferior.c; I guess it
should be exported?
 
> Alternatively you could make sure you call current_process (),
> after temporarily   having switched the current inferior, like
> we do a bit below.

Hmm, I want to guard against find_one_thread blowing up due to
a NULL proc->thread_agent -- but "proc" is always refering to
current_process () as well.  This is probably incorrect too,
and find_one_thread ought to use get_thread_process?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2009-04-03 19:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 22:57 [rfa/gdbserver] " Ulrich Weigand
2009-01-22  9:18 ` Doug Evans
2009-01-22 15:06   ` Ulrich Weigand
2009-01-23  1:08     ` Doug Evans
2009-04-03 18:07       ` [rfa/gdbserver] Updated: " Ulrich Weigand
2009-04-03 18:26         ` Pedro Alves
2009-04-03 19:20           ` Ulrich Weigand [this message]
2009-04-03 19:24             ` Pedro Alves
2009-04-03 20:17               ` Ulrich Weigand
2009-04-03 18:29         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904031920.n33JK9Mn029781@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=dje@google.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox