From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19062 invoked by alias); 3 Apr 2009 14:47:51 -0000 Received: (qmail 19053 invoked by uid 22791); 3 Apr 2009 14:47:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Apr 2009 14:47:45 +0000 Received: (qmail 29435 invoked from network); 3 Apr 2009 14:46:43 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Apr 2009 14:46:43 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit, gdbserver] Fix gdbserver on SPU Date: Fri, 03 Apr 2009 14:47:00 -0000 User-Agent: KMail/1.9.10 Cc: "Ulrich Weigand" References: <200904031440.n33Eeh93024037@d12av02.megacenter.de.ibm.com> In-Reply-To: <200904031440.n33Eeh93024037@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904031547.59755.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00062.txt.bz2 On Friday 03 April 2009 15:40:43, Ulrich Weigand wrote: > Hello, > > this patch fixes gdbserver for the SPU target, which was quite broken > since the recent multi-process merge. Many of the spu-low.c routines > were not fully adapted to common code changes, so it didn't even > compile ... Argh, very sorry about it. Hmm, I was just noticing... Does this file have any dependency on SPU specific headers? For the next time, can one build this file with a regular ppc gcc? > In addition, I've run into a bug in prepare_resume_reply: > it wouldn't null-terminate the T packet on targets without thread > support, causing GDB to receive garbage. Thanks! -- Pedro Alves