Re: [RFC] Special casing dtors?

Keith Seitz
2009-03-27T02:35:21Z

Daniel Jacobowitz wrote:

> I remember, about five years ago, doing some serious surgery on the
> way the stabs reader reported constructors and destructors. If I had
> to guess, I'd say this code was needed before that and/or for GCC 2.x.
> But 2.x is pretty scarce on the ground nowadays anyway. Either that,
> or something for HP aCC.

Eeew... I didn't even think of other compilers and other debug formats.
I will do what I can to test on some other platforms, but I hope some
kind soul(s) out there will help me/us out by checking some environments
to which I do not have access (anything non-GNU/Linux & cygwin). [Pretty
please?]

> Anyway, good riddance if your patch works! What's the new PASS?

It's "PASS: gdb.cp/templates.exp: destructor breakpoint". (Big surprise,
no? Destructors just seem to work if they are not considered "special." :-)

Now, there might be ways to tickle something that this patch removes,
but my belief is that we can always dig up the code out of CVS and
reapply, this time with appropriate comments and test cases to explain
WHY it is necessary.

Keith

PS. Tom Tromey pointed out to me that if this patch goes in, the
function "get_destructor_fn_field" will become superfluous. I will, of
course, submit a revised patch for that when/if the time comes.