Re: [RFC] Special casing dtors?

Tom Tromey
2009-03-26T22:06:21Z

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> I've been looking a bit at a patch (in Fedora) which fixes
Keith> prms/1112, and I notice that both valops.c and linespec.c treat
Keith> destructors as "special case"s -- but nowhere does it say WHY.

Keith> I've searched through all the history I can find about this (including
Keith> the Cygnus internal ueberbaum), and all I've been able to discover is
Keith> that this has been in a LONG time (before 1990).

Keith> So out of curiosity, I removed all those special cases, and lo! There
Keith> were no new failures, and one new pass in the testsuite (on x86, CVS
Keith> HEAD).

Keith> Can anyone explain to me either why gdb treats dtors differently from
Keith> "normal" methods or why we shouldn't commit something like the
Keith> attached patch?

Given all the above, I would guess that removing this is the right
thing to do. Anything that deletes code *and* improves the test
results can only be good :-)

Give it a few days; if nobody chimes in with a reason for this
mysterious special case, go ahead and check this in.

Tom