Re: [RFC] Special casing dtors?

Tom Tromey
2009-04-24T06:06:25Z

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Keith> Can you apply the attached patch to your tree and try again?

Pedro> Since this stabs patch in now in HEAD, I've redone the testing. I
Pedro> confirm that with this patch installed, your original patch doesn't
Pedro> introduce any new failures on the templates.exp test on
Pedro> stabs --- gcc 4.2, or head. Yay!

Keith> So, I guess my position is that since stabs is so darn broken any way,
Keith> we might as well apply the patch and deal with the fallout. At least
Keith> then we'll know (and hopefully document) WHY all this special casing of
Keith> dtors is necessary.

Pedro> On my end, your original patch is clear to go in.

I re-read this whole thread this evening, and as far as I can tell,
the original cleanup patch is ok. Early in the thread, Keith said
he'd send a new one that also removed get_destructor_fn_field.
Keith, could you do that?

thanks,
Tom