Re: [RFA] Fix crash on Linux 2.4 when threaded program exits

Pedro Alves
2009-04-01T18:42:40Z

On Wednesday 01 April 2009 19:22:20, Joel Brobecker wrote:

> 2009-04-01 Joel Brobecker <brobecker@adacore.com>
>
> * linux-nat.c (linux_nat_filter_events): Do not delete the lwp if
> this is the last one.
>
> Tested on x86-linux (with a 2.4.21 Linux kernel). It fixes ~25 failures.
> Tested on x86_64-linux (with a 2.6 kernel). No regression.
>
> Does this look correct?

Yes, this is OK.

The comments about ntpl and thread exit notifications on nptl
are confusing to a reader considering Linux 2.6. They could do
with a:

s/In the nptl thread model/In the nptl thread model on Linux 2.4/.

wait_lwp does mention this 2.4 + backported nptl artifact explicitly.

--
Pedro Alves