Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Christophe LYON <christophe.lyon@st.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] obvious pattern fix in gdb.base/step-line.exp
Date: Wed, 01 Apr 2009 18:32:00 -0000	[thread overview]
Message-ID: <20090401183240.GD8766@adacore.com> (raw)
In-Reply-To: <49D21E7E.8080708@st.com>

> But I am not 100% sure how to interpret the ANSI C spec regarding the  
> #line directive: when the name of the source file has no path (as in  
> step-line.c, where #line xx "step-line.c" is used), which path should be  
> considered?

Not sure either. Perhaps it's just unspecified?

> So... is this a bug in the test, in my compiler? If in my compiler,
> then  I am not sure it's a good idea to apply my fix to the testsuite
> :-)

I'm OK with leaving the testcase untouched if we don't need to.
However, I think it's worth mentioning again what happens in
the Ada case:

    % gnatmake -g `pwd`/foo
    gcc -c -I/home/brobecke/toto/ -g -I- /home/brobecke/toto/foo.adb
    gnatbind -x foo.ali
    gnatlink foo.ali -g

Then inserting a breakpoint on procedure Foo:

    (gdb) b foo
    Breakpoint 1 at 0x401f0c: file /home/brobecke/toto/foo.adb, line 4.

In my opinion, the current behavior in that case is fine too.

-- 
Joel


  reply	other threads:[~2009-04-01 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 14:05 Christophe LYON
2009-03-27 18:53 ` Joel Brobecker
2009-03-30 13:51   ` Christophe LYON
2009-03-30 18:23     ` Joel Brobecker
2009-03-31 15:25       ` Christophe LYON
2009-04-01 18:32         ` Joel Brobecker [this message]
2009-04-02  8:52           ` Christophe LYON
2009-04-17 17:07             ` Christophe LYON
2009-04-17 17:30               ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401183240.GD8766@adacore.com \
    --to=brobecker@adacore.com \
    --cc=christophe.lyon@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox