From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16152 invoked by alias); 30 Mar 2009 22:07:23 -0000 Received: (qmail 15997 invoked by uid 22791); 30 Mar 2009 22:07:21 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Mar 2009 22:07:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D9D1E2BAB8F; Mon, 30 Mar 2009 18:07:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 393Aj56b+ViT; Mon, 30 Mar 2009 18:07:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 992F02BAB0D; Mon, 30 Mar 2009 18:07:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 79F78F5899; Mon, 30 Mar 2009 15:07:09 -0700 (PDT) Date: Mon, 30 Mar 2009 22:21:00 -0000 From: Joel Brobecker To: Stan Shebs Cc: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Make tracepoints into breakpoints Message-ID: <20090330220709.GC9472@adacore.com> References: <49CD275B.1020003@codesourcery.com> <20090330153348.GY9472@adacore.com> <49D10E0A.6000700@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49D10E0A.6000700@earthlink.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00695.txt.bz2 On Mon, Mar 30, 2009 at 11:23:06AM -0700, Stan Shebs wrote: > Joel Brobecker wrote: >>> *************** bpstat_what (bpstat bs) >>> *** 3324,3329 **** >>> --- 3358,3367 ---- >>> bs_class = bp_silent; >>> retval.call_dummy = 1; >>> break; >>> + + case bp_tracepoint: >>> + /* (should never occur, complain about it) */ >>> + continue; >>> } >>> current_action = table[(int) bs_class][(int) current_action]; >>> } >>> >> >> This hunk looks really strange... Out of place? First of all, I apologize of this comment, since I realize now that it was incorrect. I was completely confused because of the tabs that made it look like you were putting a continue that would kill the code just right after. If I had read the hunk more carefully, I would have realized it was a '}', not a '{'! > I was waffling on whether to make explicit errors for the impossible > cases. I suppose there should be, one can imagine a buggy target > mistakenly stopping and reporting back at a tracepoint. Oh... I did not realize that this could actually happen if we had a buggy target. Perhaps an error to help diagnose any problem, or a complaint if we want to recover nicely from target errors? Just some thoughts - I'm also fine if we prefer to recover silently. -- Joel