Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Special casing dtors?
Date: Fri, 27 Mar 2009 17:49:00 -0000	[thread overview]
Message-ID: <200903271734.56216.pedro@codesourcery.com> (raw)
In-Reply-To: <49CD099F.9040009@redhat.com>

On Friday 27 March 2009 17:15:11, Keith Seitz wrote:
> Pedro Alves wrote:
> 
> > I regtested the whole testsuite with stabs on x86_64-linux, and
> > got this with your patch:
> > 
> >  -PASS: gdb.cp/templates.exp: destructor breakpoint
> >  -PASS: gdb.cp/templates.exp: value method breakpoint
> >  +FAIL: gdb.cp/templates.exp: destructor_breakpoint (timeout)
> >  +FAIL: gdb.cp/templates.exp: value method breakpoint
> 
> To be clear: You are getting two new FAILs with the patch? That would be 
> baffling -- I don't see how the templates.exp test "destructor 
> breakpoint" could pass on anything using gcc.

Yes, the patch causes the FAILs.  The test passes on
a pristine GDB.  Here's the relevant gdb.log diff:

 break T5<int>::~T5
-Breakpoint 2 at 0x804933d: file ../../../src/gdb/testsuite/gdb.cp/templates.cc, line 478.
-(gdb) PASS: gdb.cp/templates.exp: destructor breakpoint
+[0] cancel
+[1] all
+[2] T5<int>::~T5() at ../../../src/gdb/testsuite/gdb.cp/templates.cc:478
+[3] T5<int>::~T5() at ../../../src/gdb/testsuite/gdb.cp/templates.cc:478
+> FAIL: gdb.cp/templates.exp: destructor_breakpoint (timeout)
 break T5<int>::value
-Breakpoint 3 at 0x8049359: file ../../../src/gdb/testsuite/gdb.cp/templates.cc, line 493.
-(gdb) PASS: gdb.cp/templates.exp: value method breakpoint
+Arguments must be choice numbers.
+(gdb) FAIL: gdb.cp/templates.exp: value method breakpoint

Looks like GDB thinks there are two destructor instances in T5<int>.

I just confirmed this on x86-linux, to remove 64-bit out of
the picture.

-- 
Pedro Alves


  reply	other threads:[~2009-03-27 17:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 22:39 Keith Seitz
2009-03-26 22:07 ` Tom Tromey
2009-03-26 22:39 ` Stan Shebs
2009-03-27  2:35 ` Daniel Jacobowitz
2009-03-27  8:07   ` Keith Seitz
2009-03-27 15:06     ` Pedro Alves
2009-03-27 15:41       ` Joel Brobecker
2009-03-27 17:19       ` Keith Seitz
2009-03-27 17:49         ` Pedro Alves [this message]
2009-03-27 19:05           ` Keith Seitz
2009-03-27 19:22             ` Pedro Alves
2009-03-28  0:56               ` Keith Seitz
2009-03-28  8:56                 ` Keith Seitz
2009-03-30 21:46                   ` Pedro Alves
2009-04-01 23:48                     ` Keith Seitz
2009-04-02  3:17                       ` Daniel Jacobowitz
2009-04-02 16:25                         ` Keith Seitz
2009-04-02 16:32                           ` Daniel Jacobowitz
2009-04-02  8:27                       ` Mark Kettenis
2009-04-07 20:54                       ` Pedro Alves
2009-04-07 21:26                         ` Keith Seitz
2009-04-24  6:06                         ` Tom Tromey
2009-04-24 17:54                           ` Keith Seitz
2009-04-24 22:49                             ` Tom Tromey
2009-06-16 18:41                               ` Keith Seitz
2009-03-28 21:19                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903271734.56216.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox