Re: [RFC] GDB ARIndex Linux rule cleanup

Ulrich Weigand
2009-04-15T14:00:53Z

Pierre Muller wrote:

> Index: ppc-linux-tdep.c
> ===================================================================

> -/* Wrappers to handle Linux-only registers. */
> +/* Wrappers to handle Linux-only kernel registers. */

> - /* Initialize the Linux target descriptions. */
> + /* Initialize the Linux kernel target descriptions. */

> Index: ppc-linux-tdep.h
> ===================================================================

> -/* Linux target descriptions. */
> +/* Linux kernel target descriptions. */

It seems to me that in *those* cases, we should actually use
GNU/Linux instead -- this is talking about GDB target support
for the GNU/Linux operating system on PowerPC, and not specifically
related to the kernel only (for example, those target descriptions
are also used when analysing a core file on a remote system).

Compare for example the usage in linux-nat.c:

/* Create a prototype generic GNU/Linux target.

The other instances in your patch, where a kernel version
is specifically named, clearly refer to the Linux kernel.

I'd be fine with adding "kernel" to the text here; but I
also agree with Eli's suggestion that it might be even
better to have the ARI script recognize use of a version
number ...

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com