From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11765 invoked by alias); 27 Mar 2009 01:23:26 -0000 Received: (qmail 11757 invoked by uid 22791); 27 Mar 2009 01:23:25 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Mar 2009 01:23:21 +0000 Received: (qmail 21528 invoked from network); 27 Mar 2009 01:23:15 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Mar 2009 01:23:15 -0000 From: Pedro Alves To: Doug Evans Subject: Re: [RFA] fix crash when rerunning programs in non-stop mode Date: Fri, 27 Mar 2009 02:18:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <20090327004601.576E41C74E3@localhost> In-Reply-To: <20090327004601.576E41C74E3@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903270123.19171.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00607.txt.bz2 On Friday 27 March 2009 00:46:01, Doug Evans wrote: > One problem is that calling is_exited is problematic if > ! target_has_execution (this one I'm tripping over). Ooops. FYI, I'm going to elimiminate those particular target_has_execution checks in a near future. > Another problem is if tp == NULL, then old->inferior_ptid > is restored (this is just an observation). Ooops 2. Thank you for fixing this. > > This patch reverses the sense of what's being tested, > i.e. check for whether old->inferior_ptid restorable > instead of whether it's dead. > > Ok to check in? Ok. Thanks. > Included is a testcase to exercise the problem. Thanks, that's much appreciated. > 2009-03-26 Doug Evans > > * thread.c (do_restore_current_thread_cleanup): Redo test for > whether to restore old->inferior_ptid. > > * gdb.mi/mi-nonstop-exit.exp: New file. > * gdb.mi/non-stop-exit.c: New file. Remember to put the test logs in testsuite/ChangeLog. I'll adjust this new test to be able run it against gdbserver once this is in: http://sourceware.org/ml/gdb-patches/2009-03/msg00587.html -- Pedro Alves