From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: preserve line number when skipping prologue
Date: Thu, 26 Mar 2009 23:10:00 -0000 [thread overview]
Message-ID: <20090326224949.GM9472@adacore.com> (raw)
In-Reply-To: <m3tz5gvwe3.fsf@fleche.redhat.com>
> If I set a breakpoint on line 3, gdb reports line 7.
>
> (gdb) b 3
> Breakpoint 1 at 0x80483c5: file m.c, line 7.
>
> But if I set one on line 9, another non-executable line, gdb reports
> line 9:
>
> (gdb) b 9
> Breakpoint 2 at 0x80483d1: file m.c, line 9.
I agree that we need to be consistent between the two cases!
I don't know which one I prefer, though. Actually, I think I would
prefer if GDB reported the real line on which it was inserted. But
that would be a change of behavior from before, and that could
have ramifications that could potentially annoys the users
(on the "clear" command, for instance).
> 2009-03-26 Tom Tromey <tromey@redhat.com>
>
> * breakpoint.c (resolve_sal_pc): Preserve original line number
> when skipping prologue.
So I think that your patch is the most reasonable approach
--
Joel
next prev parent reply other threads:[~2009-03-26 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 21:06 Tom Tromey
2009-03-26 23:10 ` Joel Brobecker [this message]
2009-03-26 23:45 ` Tom Tromey
2009-03-27 0:46 ` Joel Brobecker
2009-03-27 2:19 ` Daniel Jacobowitz
2009-03-27 16:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326224949.GM9472@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox