From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8421 invoked by alias); 26 Mar 2009 15:29:06 -0000 Received: (qmail 7893 invoked by uid 22791); 26 Mar 2009 15:28:59 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Mar 2009 15:28:51 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2QFSQan027574; Thu, 26 Mar 2009 11:28:26 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2QFSJCY022030; Thu, 26 Mar 2009 11:28:19 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2QFSOpp004545; Thu, 26 Mar 2009 11:28:25 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n2QFSL5l032368; Thu, 26 Mar 2009 16:28:22 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n2QFSKGE032361; Thu, 26 Mar 2009 16:28:20 +0100 Date: Thu, 26 Mar 2009 17:02:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch/rfc] Recognize non-DW_AT_location symbols Message-ID: <20090326152820.GA11833@host0.dyn.jankratochvil.net> References: <20090320150248.GA12530@adacore.com> <20090320182215.GC12530@adacore.com> <20090320183838.GA8318@host0.dyn.jankratochvil.net> <20090320191841.GE12530@adacore.com> <20090323173115.GA19319@adacore.com> <20090323173741.GA14334@host0.dyn.jankratochvil.net> <20090323224736.GL9472@adacore.com> <20090324213956.GA10086@host0.dyn.jankratochvil.net> <20090325090154.GA22235@host0.dyn.jankratochvil.net> <20090326002940.GI9472@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090326002940.GI9472@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00591.txt.bz2 Hi Joel, On Thu, 26 Mar 2009 01:29:40 +0100, Joel Brobecker wrote: > I don't understand what you are trying to explain in your comment. > The way I came to the conclusion that we shouldn't create a symbol > for DIEs that have a non-zero DW_AT_declaration is that the DWARF > reference calls them as "incomplete, or non-defining" declarations. thanks for this hint, I read now the DWARF3 section 4.1 points 3+4 again and I did not consider a _declaration_ just cannot decide if its target object is optimized out or not. Now your simple condition (!die_is_declaration (die, cu)) makes sense to me as it is in fact just directly written down in C the DWARF citation: that is, with no DW_AT_declaration attribute > In your comment, you are hinting at a C++ situation, so I'm guessing > that this situation is relevant to this thread and gave you a little bit > of trouble. Would you like to elaborate? If you start creating `optimized-out definitions' out of some declarations the situation gets complicated to keep the whole testsuite regression free especially wrt C++ code. To be more specific I considered it risky for example for the case of: namespace A { static int var = 2; } int main (void) { int var = 1; /* Access `var' containing 1. */ { using A::var; /* Access `var' now containing 2. */ } return 0; } So that starting to ignore the inner `var' declaration' would make `var==1' accessible in the inner block from GDB. But in this case innermost `var' is not DW_AT_variable but DW_TAG_imported_declaration instead so my suspection was wrong. I find tricky that cross-CU DW_AT_external _declaration_ should add_symbol_to_list but non-DW_AT_external declaration should not. This discrepancy probably comes out of that DWARF does not use DW_TAG_imported_declaration for cross-CU imports. Going to post a separate mail/patch for it. Closed PR gdb/10002 is invalid as it was affected by my DW_AT_declaration misunderstanding (as it is using DW_AT_declaration but DWARF is talking only about the case for DW_AT_declaration not present).. Also removed this KFAIL on gdb/10002 and wrote in gdb.dwarf2/dw2-noloc.exp: # `print file_extern_locno_unresolvable' currently prints # Address of symbol "file_extern_locno_unresolvable" is unknown. # As DW_AT_declaration is not present in this DIE # it should print . As usefulness of such DIE is not # clear its resolution is not being tested. Maybe this testcase could also test the combination with DW_AT_declaration... > If you want to, we can commit the patch as is, with or without the > comment, Checked-in without the comment. Just changed gdb.dwarf2/dw2-noloc.exp as described above: http://sourceware.org/ml/gdb-cvs/2009-03/msg00203.html Thanks, Jan gdb/ 2009-03-26 Joel Brobecker Recognize missing DW_AT_location as . * dwarf2read.c (new_symbol ): Call add_symbol_to_list. gdb/testsuite/ 2009-03-26 Jan Kratochvil * gdb.dwarf2/dw2-noloc-main.c: New file. * gdb.dwarf2/dw2-noloc.S: New symbols matrix. (.text): Remove. (.data): New. (DW_AT_stmt_list, .debug_line, DW_AT_frame_base): Remove. (DW_AT_low_pc, DW_AT_high_pc): Reference `dw2-noloc-main.c'. (DW_TAG_subprogram func_cu1, noloc): Remove. (main): New. * gdb.dwarf2/dw2-noloc.exp: Use prepare_for_testing, compile also `dw2-noloc-main.c'. Test the new DIEs from `dw2-noloc.S'. (file_symbols): New procedure. --- src/gdb/dwarf2read.c 2009/03/20 22:00:10 1.297 +++ src/gdb/dwarf2read.c 2009/03/26 14:47:18 1.298 @@ -7659,6 +7659,12 @@ SYMBOL_CLASS (sym) = LOC_UNRESOLVED; add_symbol_to_list (sym, &global_symbols); } + else if (!die_is_declaration (die, cu)) + { + /* Use the default LOC_OPTIMIZED_OUT class. */ + gdb_assert (SYMBOL_CLASS (sym) == LOC_OPTIMIZED_OUT); + add_symbol_to_list (sym, cu->list_in_scope); + } } break; case DW_TAG_formal_parameter: --- src/gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c +++ src/gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c 2009-03-26 14:49:00.626311000 +0000 @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2009 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +asm (".globl cu_text_start"); +asm ("cu_text_start:"); + +int +main (void) +{ + return 0; +} + +asm (".globl cu_text_end"); +asm ("cu_text_end:"); --- src/gdb/testsuite/gdb.dwarf2/dw2-noloc.S 2009/01/03 05:58:04 1.4 +++ src/gdb/testsuite/gdb.dwarf2/dw2-noloc.S 2009/03/26 14:47:19 1.5 @@ -15,16 +15,35 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ - .text -.Lbegin_text1: - .globl func_cu1 - .type func_cu1, %function -func_cu1: -.Lbegin_func_cu1: - .int 0 -.Lend_func_cu1: - .size func_cu1, .-func_cu1 -.Lend_text1: + .data + + .globl file_locaddr_resolvable +file_locaddr_resolvable: + .globl file_locempty_resolvable +file_locempty_resolvable: + .globl file_locno_resolvable +file_locno_resolvable: + .globl file_extern_locaddr_resolvable +file_extern_locaddr_resolvable: + .globl file_extern_locempty_resolvable +file_extern_locempty_resolvable: + .globl file_extern_locno_resolvable +file_extern_locno_resolvable: + .globl main_local_locaddr_resolvable +main_local_locaddr_resolvable: + .globl main_local_locempty_resolvable +main_local_locempty_resolvable: + .globl main_local_locno_resolvable +main_local_locno_resolvable: + .globl main_extern_locaddr_resolvable +main_extern_locaddr_resolvable: + .globl main_extern_locno_resolvable +main_extern_locno_resolvable: + .globl main_extern_locempty_resolvable +main_extern_locempty_resolvable: + +resolvable: + .4byte 1234567890 /* Debug information */ @@ -39,36 +58,169 @@ /* CU die */ .uleb128 1 /* Abbrev: DW_TAG_compile_unit */ - .4byte .Lline1_begin /* DW_AT_stmt_list */ - .4byte .Lend_text1 /* DW_AT_high_pc */ - .4byte .Lbegin_text1 /* DW_AT_low_pc */ + .4byte cu_text_end /* DW_AT_high_pc */ + .4byte cu_text_start /* DW_AT_low_pc */ .ascii "file1.txt\0" /* DW_AT_name */ .ascii "GNU C 3.3.3\0" /* DW_AT_producer */ .byte 1 /* DW_AT_language (C) */ - /* func_cu1 */ - .uleb128 2 /* Abbrev: DW_TAG_subprogram */ - .byte 1 /* DW_AT_external */ - .byte 1 /* DW_AT_decl_file */ - .byte 2 /* DW_AT_decl_line */ - .ascii "func_cu1\0" /* DW_AT_name */ - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ - .4byte .Lbegin_func_cu1 /* DW_AT_low_pc */ - .4byte .Lend_func_cu1 /* DW_AT_high_pc */ - .byte 1 /* DW_AT_frame_base: length */ - .byte 0x55 /* DW_AT_frame_base: DW_OP_reg5 */ - .Ltype_int: .uleb128 3 /* Abbrev: DW_TAG_base_type */ .ascii "int\0" /* DW_AT_name */ .byte 4 /* DW_AT_byte_size */ .byte 5 /* DW_AT_encoding */ - .uleb128 4 /* Abbrev: DW_TAG_variable */ - .ascii "noloc\0" /* DW_AT_name */ + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "file_locaddr_resolvable\0" /* DW_AT_name */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "file_locaddr_unresolvable\0" /* DW_AT_name */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "file_locempty_resolvable\0" /* DW_AT_name */ + .byte 0 /* DW_AT_location */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "file_locempty_unresolvable\0" /* DW_AT_name */ + .byte 0 /* DW_AT_location */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ + .ascii "file_locno_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ + .ascii "file_locno_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "file_extern_locaddr_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "file_extern_locaddr_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "file_extern_locempty_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 0 /* DW_AT_location */ + .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "file_extern_locempty_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 0 /* DW_AT_location */ + .byte 1 /* DW_AT_external */ + + .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ + .ascii "file_extern_locno_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 1 /* DW_AT_external */ + + .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ + .ascii "file_extern_locno_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 1 /* DW_AT_external */ + + /* main */ + .uleb128 6 /* Abbrev: DW_TAG_subprogram */ + .byte 1 /* DW_AT_decl_file */ + .byte 2 /* DW_AT_decl_line */ + .ascii "main\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .4byte cu_text_start /* DW_AT_low_pc */ + .4byte cu_text_end /* DW_AT_high_pc */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "main_local_locaddr_resolvable\0" /* DW_AT_name */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "main_local_locaddr_unresolvable\0" /* DW_AT_name */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "main_local_locempty_resolvable\0" /* DW_AT_name */ + .byte 0 /* DW_AT_location */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ + .ascii "main_local_locempty_unresolvable\0" /* DW_AT_name */ + .byte 0 /* DW_AT_location */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ + .ascii "main_local_locno_resolvable\0" /* DW_AT_name */ .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ + .ascii "main_local_locno_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "main_extern_locaddr_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "main_extern_locaddr_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 2f - 1f /* DW_AT_location */ +1: .byte 3 /* DW_OP_addr */ + .4byte resolvable /* */ +2: .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "main_extern_locempty_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 0 /* DW_AT_location */ + .byte 1 /* DW_AT_external */ + + .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ + .ascii "main_extern_locempty_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 0 /* DW_AT_location */ .byte 1 /* DW_AT_external */ + .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ + .ascii "main_extern_locno_resolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 1 /* DW_AT_external */ + + .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ + .ascii "main_extern_locno_unresolvable\0" /* DW_AT_name */ + .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ + .byte 1 /* DW_AT_external */ + + .byte 0 /* End of children of main */ + .byte 0 /* End of children of CU */ .Lcu1_end: @@ -79,8 +231,6 @@ .uleb128 1 /* Abbrev code */ .uleb128 0x11 /* DW_TAG_compile_unit */ .byte 1 /* has_children */ - .uleb128 0x10 /* DW_AT_stmt_list */ - .uleb128 0x6 /* DW_FORM_data4 */ .uleb128 0x12 /* DW_AT_high_pc */ .uleb128 0x1 /* DW_FORM_addr */ .uleb128 0x11 /* DW_AT_low_pc */ @@ -94,11 +244,43 @@ .byte 0x0 /* Terminator */ .byte 0x0 /* Terminator */ - .uleb128 2 /* Abbrev code */ - .uleb128 0x2e /* DW_TAG_subprogram */ + .uleb128 3 /* Abbrev code */ + .uleb128 0x24 /* DW_TAG_base_type */ + .byte 0 /* has_children */ + .uleb128 0x3 /* DW_AT_name */ + .uleb128 0x8 /* DW_FORM_string */ + .uleb128 0xb /* DW_AT_byte_size */ + .uleb128 0xb /* DW_FORM_data1 */ + .uleb128 0x3e /* DW_AT_encoding */ + .uleb128 0xb /* DW_FORM_data1 */ + .byte 0x0 /* Terminator */ + .byte 0x0 /* Terminator */ + + .uleb128 4 /* Abbrev code (extern) */ + .uleb128 0x34 /* DW_TAG_variable */ .byte 0 /* has_children */ + .uleb128 0x3 /* DW_AT_name */ + .uleb128 0x8 /* DW_FORM_string */ + .uleb128 0x49 /* DW_AT_type */ + .uleb128 0x13 /* DW_FORM_ref4 */ .uleb128 0x3f /* DW_AT_external */ .uleb128 0xc /* DW_FORM_flag */ + .byte 0x0 /* Terminator */ + .byte 0x0 /* Terminator */ + + .uleb128 5 /* Abbrev code (bare) */ + .uleb128 0x34 /* DW_TAG_variable */ + .byte 0 /* has_children */ + .uleb128 0x3 /* DW_AT_name */ + .uleb128 0x8 /* DW_FORM_string */ + .uleb128 0x49 /* DW_AT_type */ + .uleb128 0x13 /* DW_FORM_ref4 */ + .byte 0x0 /* Terminator */ + .byte 0x0 /* Terminator */ + + .uleb128 6 /* Abbrev code */ + .uleb128 0x2e /* DW_TAG_subprogram */ + .byte 1 /* has_children */ .uleb128 0x3a /* DW_AT_decl_file */ .uleb128 0xb /* DW_FORM_data1 */ .uleb128 0x3b /* DW_AT_decl_line */ @@ -111,30 +293,30 @@ .uleb128 0x1 /* DW_FORM_addr */ .uleb128 0x12 /* DW_AT_high_pc */ .uleb128 0x1 /* DW_FORM_addr */ - .uleb128 0x40 /* DW_AT_frame_base */ - .uleb128 0xa /* DW_FORM_block1 */ .byte 0x0 /* Terminator */ .byte 0x0 /* Terminator */ - .uleb128 3 /* Abbrev code */ - .uleb128 0x24 /* DW_TAG_base_type */ + .uleb128 7 /* Abbrev code (location) */ + .uleb128 0x34 /* DW_TAG_variable */ .byte 0 /* has_children */ .uleb128 0x3 /* DW_AT_name */ .uleb128 0x8 /* DW_FORM_string */ - .uleb128 0xb /* DW_AT_byte_size */ - .uleb128 0xb /* DW_FORM_data1 */ - .uleb128 0x3e /* DW_AT_encoding */ - .uleb128 0xb /* DW_FORM_data1 */ + .uleb128 0x2 /* DW_AT_location */ + .uleb128 0xa /* DW_FORM_block1 */ + .uleb128 0x49 /* DW_AT_type */ + .uleb128 0x13 /* DW_FORM_ref4 */ .byte 0x0 /* Terminator */ .byte 0x0 /* Terminator */ - .uleb128 4 /* Abbrev code */ + .uleb128 8 /* Abbrev code (location+extern) */ .uleb128 0x34 /* DW_TAG_variable */ .byte 0 /* has_children */ .uleb128 0x3 /* DW_AT_name */ .uleb128 0x8 /* DW_FORM_string */ .uleb128 0x49 /* DW_AT_type */ .uleb128 0x13 /* DW_FORM_ref4 */ + .uleb128 0x2 /* DW_AT_location */ + .uleb128 0xa /* DW_FORM_block1 */ .uleb128 0x3f /* DW_AT_external */ .uleb128 0xc /* DW_FORM_flag */ .byte 0x0 /* Terminator */ @@ -142,69 +324,3 @@ .byte 0x0 /* Terminator */ .byte 0x0 /* Terminator */ - -/* Line table */ - .section .debug_line -.Lline1_begin: - .4byte .Lline1_end - .Lline1_start /* Initial length */ -.Lline1_start: - .2byte 2 /* Version */ - .4byte .Lline1_lines - .Lline1_hdr /* header_length */ -.Lline1_hdr: - .byte 1 /* Minimum insn length */ - .byte 1 /* default_is_stmt */ - .byte 1 /* line_base */ - .byte 1 /* line_range */ - .byte 0x10 /* opcode_base */ - - /* Standard lengths */ - .byte 0 - .byte 1 - .byte 1 - .byte 1 - .byte 1 - .byte 0 - .byte 0 - .byte 0 - .byte 1 - .byte 0 - .byte 0 - .byte 1 - .byte 0 - .byte 0 - .byte 0 - - /* Include directories */ - .byte 0 - - /* File names */ - .ascii "file1.txt\0" - .uleb128 0 - .uleb128 0 - .uleb128 0 - - .byte 0 - -.Lline1_lines: - .byte 0 /* DW_LNE_set_address */ - .uleb128 5 - .byte 2 - .4byte .Lbegin_func_cu1 - - .byte 3 /* DW_LNS_advance_line */ - .sleb128 3 /* ... to 4 */ - - .byte 1 /* DW_LNS_copy */ - - .byte 1 /* DW_LNS_copy (second time as an end-of-prologue marker) */ - - .byte 0 /* DW_LNE_set_address */ - .uleb128 5 - .byte 2 - .4byte .Lend_func_cu1 - - .byte 0 /* DW_LNE_end_of_sequence */ - .uleb128 1 - .byte 1 - -.Lline1_end: --- src/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp 2009/01/03 05:58:04 1.4 +++ src/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp 2009/03/26 14:47:19 1.5 @@ -24,25 +24,109 @@ return 0 } -set testfile "dw2-noloc" -set srcfile ${testfile}.S -set binfile ${objdir}/${subdir}/${testfile}.x - -if { [gdb_compile "${srcdir}/${subdir}/main.c" "main.o" object {debug}] != "" } { +if { [prepare_for_testing dw2-noloc.exp "dw2-noloc" {dw2-noloc-main.c dw2-noloc.S} {nodebug}] } { return -1 } -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${testfile}.o" object {nodebug}] != "" } { - return -1 +# Symbols have the form: {file,main}_loc{addr,empty,no}_{,un}resolvable +# file: Symbol DIE is placed in DW_TAG_compile_unit. +# main: Symbol DIE is placed in DW_TAG_subprogram. +# locaddr: DW_AT_location is using DW_FORM_block DW_OP_addr . +# locempty: DW_AT_location has zero DW_FORM_block size. +# locno: DW_AT_location is not present. +# resolvable: .symtab entry exists for this symbol name. +# unresolvable: .symtab entry does not exist for this symbol name. +# DW_AT_declaration is not present in any of these DIEs. + +proc file_symbols {type} { + global pf_prefix + set old_prefix $pf_prefix + lappend pf_prefix "$type:" + + global gdb_prompt + + gdb_test "print file_locaddr_resolvable" "= 1234567890" + gdb_test "ptype file_locaddr_resolvable" "type = int" + + gdb_test "print file_locaddr_unresolvable" "= 1234567890" + gdb_test "ptype file_locaddr_unresolvable" "type = int" + + gdb_test "print file_locempty_resolvable" "= " + gdb_test "ptype file_locempty_resolvable" "type = int" + + gdb_test "print file_locempty_unresolvable" "= " + gdb_test "ptype file_locempty_unresolvable" "type = int" + + gdb_test "print file_locno_resolvable" "= " + gdb_test "ptype file_locno_resolvable" "type = int" + + gdb_test "print file_locno_unresolvable" "= " + gdb_test "ptype file_locno_unresolvable" "type = int" + + gdb_test "print file_extern_locaddr_resolvable" "= 1234567890" + gdb_test "ptype file_extern_locaddr_resolvable" "type = int" + + gdb_test "print file_extern_locaddr_unresolvable" "= 1234567890" + gdb_test "ptype file_extern_locaddr_unresolvable" "type = int" + + gdb_test "print file_extern_locempty_resolvable" "= " + gdb_test "ptype file_extern_locempty_resolvable" "type = int" + + gdb_test "print file_extern_locempty_unresolvable" "= " + gdb_test "ptype file_extern_locempty_unresolvable" "type = int" + + gdb_test "print file_extern_locno_resolvable" "= 1234567890" + gdb_test "ptype file_extern_locno_resolvable" "type = int" + + # `print file_extern_locno_unresolvable' currently prints + # Address of symbol "file_extern_locno_unresolvable" is unknown. + # As DW_AT_declaration is not present in this DIE + # it should print . As usefulness of such DIE is not + # clear its resolution is not being tested. + + set pf_prefix $old_prefix } -if { [gdb_compile "${testfile}.o main.o" "${binfile}" executable {debug}] != "" } { +file_symbols no-run + +if ![runto_main] { return -1 } -gdb_exit -gdb_start -gdb_reinitialize_dir $srcdir/$subdir -gdb_load ${binfile} +file_symbols in-main + + +gdb_test "print main_local_locaddr_resolvable" "= 1234567890" +gdb_test "ptype main_local_locaddr_resolvable" "type = int" + +gdb_test "print main_local_locaddr_unresolvable" "= 1234567890" +gdb_test "ptype main_local_locaddr_unresolvable" "type = int" + +gdb_test "print main_local_locempty_resolvable" "= " +gdb_test "ptype main_local_locempty_resolvable" "type = int" + +gdb_test "print main_local_locempty_unresolvable" "= " +gdb_test "ptype main_local_locempty_unresolvable" "type = int" + +gdb_test "print main_local_locno_resolvable" "= " +gdb_test "ptype main_local_locno_resolvable" "type = int" + +gdb_test "print main_local_locno_unresolvable" "= " +gdb_test "ptype main_local_locno_unresolvable" "type = int" + +gdb_test "print main_extern_locaddr_resolvable" "= 1234567890" +gdb_test "ptype main_extern_locaddr_resolvable" "type = int" + +gdb_test "print main_extern_locaddr_unresolvable" "= 1234567890" +gdb_test "ptype main_extern_locaddr_unresolvable" "type = int" + +gdb_test "print main_extern_locempty_resolvable" "= " +gdb_test "ptype main_extern_locempty_resolvable" "type = int" + +gdb_test "print main_extern_locempty_unresolvable" "= " +gdb_test "ptype main_extern_locempty_unresolvable" "type = int" + +gdb_test "print main_extern_locno_resolvable" "= 1234567890" +gdb_test "ptype main_extern_locno_resolvable" "type = int" -gdb_test "print noloc" "Address of symbol \"noloc\" is unknown." "print noloc" +# For `main_extern_locno_unresolvable' see `file_extern_locno_unresolvable'.