From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11711 invoked by alias); 25 Mar 2009 16:54:48 -0000 Received: (qmail 11684 invoked by uid 22791); 25 Mar 2009 16:54:47 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Mar 2009 16:54:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0EC3B2BAB56; Wed, 25 Mar 2009 12:54:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FInRiPmr9+vJ; Wed, 25 Mar 2009 12:54:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C91732BAB49; Wed, 25 Mar 2009 12:54:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3247B5BD21; Wed, 25 Mar 2009 09:54:33 -0700 (PDT) Date: Wed, 25 Mar 2009 17:49:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Add task-specific breakpoint capability... Message-ID: <20090325165433.GZ9472@adacore.com> References: <20090324203319.GB24100@adacore.com> <20090325162141.GW9472@adacore.com> <20090325162711.GX9472@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00554.txt.bz2 > It seems like it would be more efficient to combine > breakpoint_thread_match and breakpoint_ada_task_match, so we only > have a single loop over all breakpoint locations. > This is probably not very important. That's a good idea. The condition inside breakpoint_thread_match gets a little too big and nested for my own taste, so I'll reorganize the condition a little bit first, and then post a new patch on top of that. Please wait, testing in progress... -- Joel