From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30345 invoked by alias); 24 Mar 2009 17:09:59 -0000 Received: (qmail 30335 invoked by uid 22791); 24 Mar 2009 17:09:58 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_14,J_CHICKENPOX_54,J_CHICKENPOX_55 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Mar 2009 17:09:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 55A3B2BAB2C; Tue, 24 Mar 2009 13:09:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id W2NOHiFlbIXm; Tue, 24 Mar 2009 13:09:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C67972BAACF; Tue, 24 Mar 2009 13:09:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7AC455BD21; Tue, 24 Mar 2009 10:09:44 -0700 (PDT) Date: Tue, 24 Mar 2009 20:33:00 -0000 From: Joel Brobecker To: don.lee@sunplusct.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Support new target S+core 3, a variant of S+core Message-ID: <20090324170944.GA21622@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00531.txt.bz2 Don, > 2009-03-20 Don Lee : > > Support new target S+core 3, which is a variant of S+core > > * gdb/score-tdep.c: support new target S+core 3 > * gdb/score-tdep.c: Ditto. These changes were privately approved by Qinwei, so they can be checked in. Before you do so, I have a few comments, mostly procedural, so they should not require too much work. You will need to have write access priviledges to GDB. If you don't have these priviledges, can you please visit this web page? http://www.sourceware.org/cgi-bin/pdw/ps_form.cgi Once you write access have been granted, please add yourself to the WRITE AFTER APPROVAL section in the gdb/MAINTAINERS file. Please make sure to send the associated patch and ChangeLog entry to gdb-patches, so we can all know that the change was made. About the score changes, the ChangeLog entry for your changes to GDB are meant to be added at the start of the gdb/ChangeLog file - filenames in your entry should be relative to the ChangeLog file, so omit the "gdb/" in the filenames above. Also, there is a typo above, as you mentioned the same filename twice. And finally, you should be using sentences, which mean starting with a capital letter, and ending with a period. Here is an example of an acceptable entry: * score-tdep.h, score-tdep.c: Add support for S+core 3. The change in gdb/configure.ac is also approved, but please repost the patch with the associated ChangeLog entry as well. And finally, it would be great if you could post your patches with a different encoding than "applica/octet-stream", as this makes it harder to quote the contents of your patches when replying to your emails. Fixing this might be as simple as using score.diff as opposed to score.patch (but I see that you use Lotus Notes, so perhaps not as easy). -- Joel