Re: [patch] Fix a crash when displaying variables from shared library.

Joel Brobecker
2009-03-06T18:47:02Z

> Attached patch does that.

Thanks!

> I didn't touch similarly mis-named xcoff_solib_address, because I can't
> see any use of that symbol. Perhaps it should be deleted?

This function is actually used as a #define in config/rs6000/nm-rs6000.h:

#define PC_SOLIB(PC) xcoff_solib_address(PC)

I'll change its name when I have a moment. But perhaps the whole
file could be modernized too. So let's leave it aside for now.

> 2009-03-06 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> Rename solib_address to solib_name_from_address.
> * breakpoint.c (insert_bp_location, disable_breakpoints_in_shlibs)
> (disable_breakpoints_in_unloaded_shlib): Update.
> * printcmd.c (display_uses_solib_p): Likewise.
> * stack.c (print_frame): Likewise.
> * solib.c: Rename.
> * solib.h: Rename.

Looks great. Please apply.

And thank you for taking care of this.

--
Joel