From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12703 invoked by alias); 22 Mar 2009 15:31:03 -0000 Received: (qmail 12686 invoked by uid 22791); 22 Mar 2009 15:30:59 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Mar 2009 15:30:54 +0000 Received: (qmail 32711 invoked from network); 22 Mar 2009 15:30:52 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Mar 2009 15:30:52 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Submit process record and replay fourth time, 7/8 Date: Sun, 22 Mar 2009 15:37:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu , Mark Kettenis , marc.khouzam@ericsson.com, msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com References: <200903211618.n2LGIwBO018366@brahms.sibelius.xs4all.nl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903221530.52997.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00454.txt.bz2 The way this is written looks like there's a bunch of unneeded duplication. +#define I386_LINUX_RECORD_SIZE__old_kernel_stat 32 + /* Initialize the i386_linux_record_tdep. */ + i386_linux_record_tdep.size__old_kernel_stat = + I386_LINUX_RECORD_SIZE__old_kernel_stat; Are the I386_LINUX_RECORD_SIZE__XXXXX defines used for anything else other than initializing the corresponding i386_linux_record_tdep.size_XXXXX field? If not, why not drop the defines and just write i386_linux_record_tdep.size__old_kernel_stat = 32; ? Personally, I think that stamping everything with "record" in its name is a mistake. This is about the linux syscall abi, could be reused for something else... -- Pedro Alves