Re: [PATCH] Support new target S+core 3, a variant of S+core

[Joel Brobecker <brobecker@adacore.com>]

Just for the record: I just sent Don a private message asking if
Qinwei could approve the S+core part or not. So I will not address
this part.

> --- src/gdb/configure.tgt	2009-03-16 23:04:14.000000000 +0800
> +++ src.mod/gdb/configure.tgt	2009-03-17 09:26:44.000000000 +0800
> @@ -375,7 +375,11 @@
>  
>  score-*-*)
>  	# Target: S+core embedded system
> -	gdb_target_obs="score-tdep.o"
> +	gdb_target_obs="score-tdep.o corelow.o"
> +	if test -f ../sim/score/Makefile; then
> +	  gdb_sim=../sim/score/libsim.a
> +	fi
> +	build_gdbserver=yes
>  	;;
>  
>  sh*-*-linux*)


Regarding this change, I am 50-50, leaning towards accepting it.

    Cons: There is no score simulator and you are not planning on
          contributing it. So, it is a useless change as far as the FSF
          is concerned. As such, I don't see why we should accept it.
          Maintaining small local changes in your own tree is very easy.

    Pros: I can't see any.

That being said, the reason why I'm split on this is that it wouldn't
cost us much to accept the change. I don't see how it could cause
any trouble.

GDB Global Maintainers:

Do we have a policy on this sort of change?

-- 
Joel