From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1822 invoked by alias); 18 Mar 2009 15:00:17 -0000 Received: (qmail 1808 invoked by uid 22791); 18 Mar 2009 15:00:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 15:00:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id ECFDD2BAC13; Wed, 18 Mar 2009 11:00:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1lRaOWIWMTk3; Wed, 18 Mar 2009 11:00:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 712EF2BAB78; Wed, 18 Mar 2009 11:00:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1B3C4F5CFA; Wed, 18 Mar 2009 08:00:06 -0700 (PDT) Date: Wed, 18 Mar 2009 15:16:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Vladimir Prus , gdb-patches@sourceware.org Subject: Re: [1/3] broken -thread-info output in non-stop mode, suppress_stop_observer Message-ID: <20090318150006.GD18396@adacore.com> References: <200903170621.02808.pedro@codesourcery.com> <200903171026.31197.vladimir@codesourcery.com> <200903171724.54512.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200903171724.54512.pedro@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00379.txt.bz2 > Hmmm, I do wonder if we could rewrite "finish" to not rely on > bpstat_find_breakpoint after normal_stop, but to instead add a new > BPSTAT_WHAT_FINISH and handle it from within handle_inferior_event's > internal breakpoint handling switch (where we handle > BPSTAT_WHAT_STEP_RESUME, etc.). Since that runs before normal_stop, > we wouldn't have to suppress the normal_stop observer. Seems like worth a try indeed. It might simplify how the "finish" command is implemented too. -- Joel