From: Alan Modra <amodra@bigpond.net.au>
To: Pierre Muller <muller@ics.u-strasbg.fr>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [RFA] fix bfd multi-arch compilation failure
Date: Wed, 18 Mar 2009 13:05:00 -0000 [thread overview]
Message-ID: <20090318114643.GK2440@bubble.grove.modra.org> (raw)
In-Reply-To: <20090318110516.GJ2440@bubble.grove.modra.org>
On Wed, Mar 18, 2009 at 09:35:16PM +1030, Alan Modra wrote:
> tweaked. This patch gets us back to just one file with alloca magic.
Missed a couple.
bfd/
* vms-hdr.c: Don't include alloca.h.
opcodes/
* cgen-opc.c: Include alloca-conf.h rather than alloca.h.
* Makefile.am: Run "make dep-am".
* Makefile.in: Regenerate.
Index: bfd/vms-hdr.c
===================================================================
RCS file: /cvs/src/src/bfd/vms-hdr.c,v
retrieving revision 1.23
diff -u -p -r1.23 vms-hdr.c
--- bfd/vms-hdr.c 23 Feb 2009 09:28:43 -0000 1.23
+++ bfd/vms-hdr.c 18 Mar 2009 11:42:36 -0000
@@ -52,10 +52,6 @@
#include "vms.h"
-#ifdef HAVE_ALLOCA_H
-#include <alloca.h>
-#endif
-
static struct module *new_module (bfd *);
static void parse_module
(bfd *, struct module *, unsigned char *, unsigned int);
Index: opcodes/cgen-opc.c
===================================================================
RCS file: /cvs/src/src/opcodes/cgen-opc.c,v
retrieving revision 1.18
diff -u -p -r1.18 cgen-opc.c
--- opcodes/cgen-opc.c 5 Jul 2007 09:49:00 -0000 1.18
+++ opcodes/cgen-opc.c 18 Mar 2009 11:42:37 -0000
@@ -19,6 +19,7 @@
with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */
+#include "alloca-conf.h"
#include "sysdep.h"
#include <stdio.h>
#include "ansidecl.h"
@@ -28,10 +29,6 @@
#include "symcat.h"
#include "opcode/cgen.h"
-#ifdef HAVE_ALLOCA_H
-#include <alloca.h>
-#endif
-
static unsigned int hash_keyword_name
(const CGEN_KEYWORD *, const char *, int);
static unsigned int hash_keyword_value
Index: opcodes/Makefile.am
===================================================================
RCS file: /cvs/src/src/opcodes/Makefile.am,v
retrieving revision 1.134
diff -u -p -r1.134 Makefile.am
--- opcodes/Makefile.am 18 Mar 2009 11:27:18 -0000 1.134
+++ opcodes/Makefile.am 18 Mar 2009 11:42:37 -0000
@@ -715,9 +715,10 @@ cgen-bitset.lo: cgen-bitset.c $(INCDIR)/
cgen-dis.lo: cgen-dis.c sysdep.h config.h $(INCDIR)/ansidecl.h \
$(INCDIR)/libiberty.h $(BFD_H) $(INCDIR)/symcat.h $(INCDIR)/opcode/cgen.h \
$(INCDIR)/opcode/cgen-bitset.h
-cgen-opc.lo: cgen-opc.c sysdep.h config.h $(INCDIR)/ansidecl.h \
- $(INCDIR)/libiberty.h $(INCDIR)/safe-ctype.h $(BFD_H) \
- $(INCDIR)/symcat.h $(INCDIR)/opcode/cgen.h $(INCDIR)/opcode/cgen-bitset.h
+cgen-opc.lo: cgen-opc.c $(INCDIR)/alloca-conf.h config.h \
+ sysdep.h $(INCDIR)/ansidecl.h $(INCDIR)/libiberty.h \
+ $(INCDIR)/safe-ctype.h $(BFD_H) $(INCDIR)/symcat.h \
+ $(INCDIR)/opcode/cgen.h $(INCDIR)/opcode/cgen-bitset.h
cr16-dis.lo: cr16-dis.c $(INCDIR)/dis-asm.h $(BFD_H) \
$(INCDIR)/ansidecl.h $(INCDIR)/symcat.h sysdep.h config.h \
$(INCDIR)/opcode/cr16.h $(INCDIR)/libiberty.h
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2009-03-18 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 23:59 Pierre Muller
2009-03-18 0:08 ` H.J. Lu
2009-03-18 11:46 ` Alan Modra
2009-03-18 13:05 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318114643.GK2440@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox