Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	 gdb-patches@sourceware.org,  tromey@redhat.com
Subject: Re: [patch] Fix a crash when displaying variables from shared  ?library.
Date: Wed, 18 Mar 2009 04:19:00 -0000	[thread overview]
Message-ID: <200903180412.43887.pedro@codesourcery.com> (raw)
In-Reply-To: <8ac60eac0903172024g4e381249t43bac2b4c9769a04@mail.gmail.com>

On Wednesday 18 March 2009 03:15:16, Joel Brobecker wrote:
> If I understand the original issue correctly, we need to restart
> the execution of our program in order to demonstrate the issue.
> Except with the extended-remote protocol, we can't do that when
> using the gdbserver, right? In other words, the "run" command with
> target remote doesn't restart the program like in the native case.
> So I'd say we kill the test for remote targets.

Right, target remote doesn't support "run" at all:

  (gdb) run
  The "remote" target does not support "run".  Try "help target" or "continue".

You'd have to disconnect/kill, and then reconnect perhaps.  Maybe
using rerun_to_main.

On Wednesday 18 March 2009 03:24:04, Paul Pluzhnikov wrote:
> On Tue, Mar 17, 2009 at 8:15 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> 
> > If I understand the original issue correctly, we need to restart
> > the execution of our program in order to demonstrate the issue.
> 
> Well, not really. You could also
>   dlopen foo.so
>   break in foo.so
>   display something referring to foo.so symbols
>   dlclose foo.so
>   re-display
> 
> But writing a portable test for that is harder.

Or that.  It may not be so hard for most targets we care
about.  See unload.exp or watchpoint-solib.exp.

> Is it as simple as removing changing fail to untested:
> 
> if { [gdb_start_cmd] < 0 } {
> -    fail "Can't run to main (2)"
> +    untested "Can't run to main (2)"
>     return 0
> }

Or not that.  :-)

> 
> Of course we might just as well skip the test, since it's not going
> to test much in that case.

Or that is fine with me too.

-- 
Pedro Alves


  reply	other threads:[~2009-03-18  4:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05  3:03 [patch] Fix a crash when displaying variables from shared library Paul Pluzhnikov
2009-02-06 21:38 ` Tom Tromey
2009-02-07  2:37   ` Paul Pluzhnikov
2009-02-11  1:46     ` Tom Tromey
2009-02-19  1:00       ` Paul Pluzhnikov
2009-02-19  7:52         ` Paul Pluzhnikov
2009-02-23  1:47         ` Joel Brobecker
2009-02-23 18:36           ` Paul Pluzhnikov
2009-03-03  2:31             ` Paul Pluzhnikov
2009-03-04  0:51               ` Tom Tromey
2009-03-04 19:26                 ` Paul Pluzhnikov
2009-03-05 20:04                   ` Joel Brobecker
2009-03-05 23:46                     ` Paul Pluzhnikov
2009-03-06  3:06                       ` Paul Pluzhnikov
2009-03-06  3:18                         ` Paul Pluzhnikov
2009-03-06 17:48                         ` Joel Brobecker
2009-03-06 18:31                           ` Paul Pluzhnikov
2009-03-06 18:47                             ` Joel Brobecker
2009-03-06 18:52                               ` Paul Pluzhnikov
2009-03-06 22:06                           ` Paul Pluzhnikov
2009-03-09 18:33                             ` Joel Brobecker
2009-03-10  2:05                               ` Paul Pluzhnikov
2009-03-10 14:31                                 ` Daniel Jacobowitz
2009-03-12  2:45                                   ` Paul Pluzhnikov
2009-03-20 20:32                                     ` Joel Brobecker
2009-03-20 20:53                                       ` Paul Pluzhnikov
2009-03-23 17:31                                         ` Joel Brobecker
2009-03-18  2:50                       ` Pedro Alves
2009-03-18  3:24                         ` [patch] Fix a crash when displaying variables from shared ?library Joel Brobecker
2009-03-18  4:06                           ` Paul Pluzhnikov
2009-03-18  4:19                             ` Pedro Alves [this message]
2009-03-18  6:54                               ` Paul Pluzhnikov
2009-03-18 17:32                                 ` Pedro Alves
2009-02-06 21:53 ` [patch] Fix a crash when displaying variables from shared library Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903180412.43887.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox