From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62243-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27533 invoked by alias); 18 Mar 2009 02:49:23 -0000
Received: (qmail 27521 invoked by uid 22791); 18 Mar 2009 02:49:22 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 02:49:15 +0000
Received: (qmail 21705 invoked from network); 18 Mar 2009 02:49:08 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 18 Mar 2009 02:49:08 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] Fix a crash when displaying variables from shared  =?iso-8859-1?q?=09library=2E?=
Date: Wed, 18 Mar 2009 02:50:00 -0000
User-Agent: KMail/1.9.10
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>,  Joel Brobecker <brobecker@adacore.com>,  tromey@redhat.com
References: <20090205030257.8A6073A6B7A@localhost> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com>
In-Reply-To: <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200903180249.10903.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00353.txt.bz2

Hi guys,

On Thursday 05 March 2009 23:46:32, Paul Pluzhnikov wrote:
> > I suggest a different approach:
> >
> > =A0| # Start the program, we should land in the program main procedure
> > =A0| if { [gdb_start_cmd] < 0 } {
> > =A0| =A0 =A0 fail "Can't run to main"
> > =A0| =A0 =A0 return -1
> > =A0| }
> > =A0|
> > =A0| gdb_test "" \
> > =A0| =A0 =A0 =A0 =A0 =A0"first \\(\\) at .*first.adb.*" \
> > =A0| =A0 =A0 =A0 =A0 =A0"start first"
> >
> > The second gdb_test should allow you to verify that the debugger
> > displays your variables correctly.
>=20
> Looks good.
>=20
> Attached is the patch I just committed.

I just noticed that this test is failing against gdbserver:

  FAIL: gdb.base/solib-display.exp: Can't run to main (2)

The problem is that gdb_start_cmd is a nop for remote targets:

proc gdb_start_cmd {args} {
...
    if [target_info exists use_gdb_stub] {
        return -1
    }

What do you think?  Should we skip this test for remote
targets, or perhaps we do things differently here?

--=20
Pedro Alves