From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62197-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1873 invoked by alias); 17 Mar 2009 07:50:12 -0000
Received: (qmail 1865 invoked by uid 22791); 17 Mar 2009 07:50:11 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Mar 2009 07:50:06 +0000
Received: (qmail 8850 invoked from network); 17 Mar 2009 07:50:04 -0000
Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 17 Mar 2009 07:50:04 -0000
From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Subject: Re: [RFC] Fix MI timings
Date: Tue, 17 Mar 2009 08:03:00 -0000
User-Agent: KMail/1.11.90 (Linux/2.6.24-24-generic; KDE/4.2.65; i686; svn-936416; 2009-03-07)
Cc: gdb-patches@sourceware.org,  Nick Roberts <nickrob@snap.net.nz>
References: <200903100010.06180.vladimir@codesourcery.com> <200903170519.25294.pedro@codesourcery.com> <200903171012.57182.vladimir@codesourcery.com>
In-Reply-To: <200903171012.57182.vladimir@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <200903171050.02729.vladimir@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00307.txt.bz2

On Tuesday 17 March 2009 10:12:56 Vladimir Prus wrote:
> On Tuesday 17 March 2009 08:19:25 Pedro Alves wrote:
> > On Monday 09 March 2009 21:36:34, Pedro Alves wrote:
> > > On Monday 09 March 2009 21:32:25, Vladimir Prus wrote:
> > > > +void mi_print_timing_maybe ();
> > >
> > >                               ^ (void) here too, please.
> > >
> > > Also, it's redundant, but the only other function declared
> > > in the header marks it explicitly as "extern",  you may want
> > > to do the same for consistency.
> >
> > I was touching this file and noticed this patch went it without
> > the '(void)'.
>
> Guess what -- it was intentional -- based on IRC conversation where
> you have said (abridged) "C compiler does not really care for that word".

Oh, it was "void" that was missing? I only meant to not add "extern" :-(

Thanks for catching,
Volodya