From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [3/3] broken -thread-info output in non-stop mode, fix it
Date: Tue, 17 Mar 2009 07:50:00 -0000 [thread overview]
Message-ID: <200903171033.28967.vladimir@codesourcery.com> (raw)
In-Reply-To: <200903170623.58562.pedro@codesourcery.com>
On Tuesday 17 March 2009 09:23:58 Pedro Alves wrote:
> This fixes the broken -thread-info output mentioned in this thread:
>
> http://sourceware.org/ml/gdb-patches/2009-03/msg00236.html
>
> ... as suggested by Vladimir, the patch makes us output ^running
> only if the target was proceeded. I've added a new observer
> (about_to_proceed), and implemented Vladimir's suggestion on top of
> it. There's this `breakpoint_proceeded' global that is used
> by the breakpoint.c module for something very similar, so I've
> moved that global into breakpoint.c, and made it static, and then
> used the same observer to set it. Since breakpoint_proceeded is
> not global anymore, we can't save/restore it when doing infcalls
> from infrun.c. What I've done instead, was to make the
> about_to_proceed observer in breakpoint.c not set breakpoint_proceeded if
> we're about to do an inferior function call. And we know we're doing
> an infcall due to this new thread_info->in_infcall flag added by the
> previous patch.
>
> Vladimir, does this look like what you were picturing?
Yes, this looks very nice, thank you.
- Volodya
prev parent reply other threads:[~2009-03-17 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 7:13 Pedro Alves
2009-03-17 7:50 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903171033.28967.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox