Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [1/3] broken -thread-info output in non-stop mode, suppress_stop_observer
Date: Tue, 17 Mar 2009 07:29:00 -0000	[thread overview]
Message-ID: <200903171026.31197.vladimir@codesourcery.com> (raw)
In-Reply-To: <200903170621.02808.pedro@codesourcery.com>

On Tuesday 17 March 2009 09:21:02 Pedro Alves wrote:
> This patch removes the suppress_stop_observer global.  As indicated
> in the comments I'm removing, this was problematic for non-stop
> mode.
>
> To fix the broken -thread-info output mentioned here:
>
>  http://sourceware.org/ml/gdb-patches/2009-03/msg00236.html
>
> ... I wanted to add a thread_info->in_infcall flag to use in
> the 3rd patch in the series.  That meant I needed to get rid of
> the suppress_resume_observer global, which then brings
> us to this.
>
> Vladimir, et al, how does this look?

I did not look very carefully at details of conditions, but the
general idea looks solid. One detail is the new command you
add in infrun.c -- can it explicitly write down *why* we need to
suppress *stopped at this point, when doing finish?

Thanks,
Volodya


  reply	other threads:[~2009-03-17  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-17  6:23 Pedro Alves
2009-03-17  7:29 ` Vladimir Prus [this message]
2009-03-17 17:27   ` Pedro Alves
2009-03-18 15:16     ` Joel Brobecker
2009-03-22 21:24     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903171026.31197.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox