From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29753 invoked by alias); 17 Mar 2009 05:19:38 -0000 Received: (qmail 29741 invoked by uid 22791); 17 Mar 2009 05:19:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Mar 2009 05:19:32 +0000 Received: (qmail 22793 invoked from network); 17 Mar 2009 05:19:27 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Mar 2009 05:19:27 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC] Fix MI timings Date: Tue, 17 Mar 2009 05:27:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , Nick Roberts References: <200903100010.06180.vladimir@codesourcery.com> <200903100032.25610.vladimir@codesourcery.com> <200903092136.34537.pedro@codesourcery.com> In-Reply-To: <200903092136.34537.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903170519.25294.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00296.txt.bz2 On Monday 09 March 2009 21:36:34, Pedro Alves wrote: > On Monday 09 March 2009 21:32:25, Vladimir Prus wrote: > > +void mi_print_timing_maybe (); > > ^ (void) here too, please. > > Also, it's redundant, but the only other function declared > in the header marks it explicitly as "extern", you may want > to do the same for consistency. > I was touching this file and noticed this patch went it without the '(void)'. Evil as I am, I went ahead and checked in the patch below. Muahahaha!!1 :-) -- Pedro Alves 2009-03-17 Pedro Alves * mi/mi-main.h (mi_print_timing_maybe): Add strict prototype, declare as extern. --- gdb/mi/mi-main.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: src/gdb/mi/mi-main.h =================================================================== --- src.orig/gdb/mi/mi-main.h 2009-03-17 05:05:10.000000000 +0000 +++ src/gdb/mi/mi-main.h 2009-03-17 05:05:42.000000000 +0000 @@ -26,11 +26,11 @@ extern void mi_load_progress (const char unsigned long total_sent, unsigned long grand_total); +extern void mi_print_timing_maybe (void); + extern char *current_token; extern int running_result_record_printed; -void mi_print_timing_maybe (); - #endif