From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14684 invoked by alias); 16 Mar 2009 21:15:19 -0000 Received: (qmail 14670 invoked by uid 22791); 16 Mar 2009 21:15:18 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 21:15:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 578462BABA3 for ; Mon, 16 Mar 2009 17:15:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XYDgdjLhESEW for ; Mon, 16 Mar 2009 17:15:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C9F322BABA1 for ; Mon, 16 Mar 2009 17:15:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EE259F5C40; Mon, 16 Mar 2009 14:15:07 -0700 (PDT) Date: Mon, 16 Mar 2009 21:19:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c Message-ID: <20090316211507.GA384@adacore.com> References: <20090316195430.GH9576@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090316195430.GH9576@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00284.txt.bz2 > 2009-03-16 Joel Brobecker > > * remote-mips.c (mips_load): Replace call to regcache_set_valid_p, > which is undefined, by call to regcache_invalidate, which should > do what the original author wanted to do. Thank you for the extra pair of eyes, guys. Patch now checked in. I was afraid that this might not be sufficient to make the remote-mips fully functional (Pedro mentioned converting this target to always-a-thread), but at least we're trying to move in the right direction... -- Joel