From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25939 invoked by alias); 16 Mar 2009 20:09:42 -0000 Received: (qmail 25929 invoked by uid 22791); 16 Mar 2009 20:09:42 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 20:09:37 +0000 Received: (qmail 3148 invoked from network); 16 Mar 2009 20:09:35 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Mar 2009 20:09:35 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c Date: Mon, 16 Mar 2009 20:20:00 -0000 User-Agent: KMail/1.9.10 Cc: Joel Brobecker References: <20090316195430.GH9576@adacore.com> In-Reply-To: <20090316195430.GH9576@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903162009.35407.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00282.txt.bz2 On Monday 16 March 2009 19:54:30, Joel Brobecker wrote: > remote-mips.c no longer builds because of this call to regcache_set_valid_p. > I couldn't find any trace of that routine in our ChangeLogs and I'm right > in the middle of a rather large change in my git directory, so I didn't > bother investigate more about this routine. > > I think that the routine that we want, right now, is called > regcache_invalidate. > I believe this was Maciej's change. > 2009-03-16 Joel Brobecker > > * remote-mips.c (mips_load): Replace call to regcache_set_valid_p, > which is undefined, by call to regcache_invalidate, which should > do what the original author wanted to do. > > Does this look plausible to anyone else? I'd just like a second pair > of eyes before I commit. > We have this in an internal MIPS tree: void regcache_invalidate (struct regcache *regcache, int regnum) { regcache_set_valid_p (regcache, regnum, 0); } So, it looks correct. This file isn't used by any FSF configuration, BTW. I don't think I converted it to always a thread, so it surely isn't working as is. -- Pedro Alves