From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24558 invoked by alias); 16 Mar 2009 19:54:38 -0000 Received: (qmail 24549 invoked by uid 22791); 16 Mar 2009 19:54:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 19:54:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A1CFB2BAB98 for ; Mon, 16 Mar 2009 15:54:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ewSYQcnV7CRp for ; Mon, 16 Mar 2009 15:54:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8BFD62BAB75 for ; Mon, 16 Mar 2009 15:54:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EAEF2F5C40; Mon, 16 Mar 2009 12:54:30 -0700 (PDT) Date: Mon, 16 Mar 2009 20:07:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c Message-ID: <20090316195430.GH9576@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="dMyqICaxQaaUjrCL" Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00280.txt.bz2 --dMyqICaxQaaUjrCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 718 remote-mips.c no longer builds because of this call to regcache_set_valid_p. I couldn't find any trace of that routine in our ChangeLogs and I'm right in the middle of a rather large change in my git directory, so I didn't bother investigate more about this routine. I think that the routine that we want, right now, is called regcache_invalidate. 2009-03-16 Joel Brobecker * remote-mips.c (mips_load): Replace call to regcache_set_valid_p, which is undefined, by call to regcache_invalidate, which should do what the original author wanted to do. Does this look plausible to anyone else? I'd just like a second pair of eyes before I commit. Thank you! -- Joel --dMyqICaxQaaUjrCL Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="remote-mips.c.diff" Content-length: 825 Index: remote-mips.c =================================================================== RCS file: /cvs/src/src/gdb/remote-mips.c,v retrieving revision 1.97 diff -u -p -r1.97 remote-mips.c --- remote-mips.c 16 Mar 2009 19:38:32 -0000 1.97 +++ remote-mips.c 16 Mar 2009 19:50:15 -0000 @@ -3276,9 +3276,9 @@ mips_load (char *file, int from_tty) to a different value than GDB thinks it has. The following ensures that the write_pc() WILL update the PC value: */ struct regcache *regcache = get_current_regcache (); - regcache_set_valid_p (regcache, - gdbarch_pc_regnum (get_regcache_arch (regcache)), - 0); + + regcache_invalidate (regcache, + gdbarch_pc_regnum (get_regcache_arch (regcache))); } if (exec_bfd) write_pc (bfd_get_start_address (exec_bfd)); --dMyqICaxQaaUjrCL--