Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tristan Gingold <gingold@adacore.com>
Subject: Re: [RFC] How to get target_ops from to_kill method?
Date: Mon, 16 Mar 2009 19:07:00 -0000	[thread overview]
Message-ID: <20090316173104.GH9294@adacore.com> (raw)
In-Reply-To: <200903161724.31544.pedro@codesourcery.com>

> > Yeah, fixing them all would be a lot of work, indeed. How about
> > we decide that, from now on, all new methods should have a target_ops
> > parameter as their first argument? Do you think that it would be
> > a good thing? We can fix the others as needed...
> 
> I can't see it a bad thing, so I'm on for it.

Excellent. So, unless I hear any objection, I'll add a comment at
the beginning of the target_ops structure that details this new
requirement.

> > > I much prefer this version over the other.  It's incremental, and
> > > doesn't add any hack or reference to the current_target global.
> > 
> > Me too. I haven't checked it in, yet, because it would become
> > unecessary if we added the target_ops parameter to the to_kill
> > method, which I can take care of.... What do you think?
> 
> If you're willing to, it sounds very good to me.  :-)

Hey, you're not the only one who's allowed to break other's builds,
you know? ;-) I'll take care of that asap. (I have to switch to
something else for the rest of the afternoon)

-- 
Joel


  reply	other threads:[~2009-03-16 17:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 16:42 Joel Brobecker
2009-03-16 17:02 ` Pedro Alves
2009-03-16 17:24   ` Joel Brobecker
2009-03-16 17:24     ` Pedro Alves
2009-03-16 19:07       ` Joel Brobecker [this message]
2009-03-16 22:22         ` Joel Brobecker
2009-03-17  0:05           ` Pedro Alves
2009-03-17 18:05             ` Joel Brobecker
2009-03-17 18:28               ` Pedro Alves
2009-03-17 19:11                 ` Joel Brobecker
2009-03-17 19:13                   ` Pedro Alves
2009-03-17 19:31                     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316173104.GH9294@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox