From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [commit/AIX] Fix error happening while loading a core file
Date: Sun, 15 Mar 2009 20:37:00 -0000 [thread overview]
Message-ID: <20090315203320.GB9576@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
This is another regression that I noticed on AIX.
The problem is that we had a check in xcoff_relocate_symtab that
was supposed to detect the case where we're debugging a core file.
The check was based on the inferior ptid being null. I replaced it
with a check against target_has_execution, which seemed more
appropriate.
Is there a routine that performs this check?
2009-03-15 Joel Brobecker <brobecker@adacore.com>
Fix an error happening while loading symbols from a core file.
* rs6000-nat.c (xcoff_relocate_symtab): Use target_has_execution
to detect whether we're debugging a core file or not.
Tested on powerpc-aix. Checked in.
--
Joel
[-- Attachment #2: rs6000-nat.diff --]
[-- Type: text/x-diff, Size: 452 bytes --]
Index: rs6000-nat.c
===================================================================
--- rs6000-nat.c (revision 146288)
+++ rs6000-nat.c (working copy)
@@ -1036,7 +1036,8 @@ xcoff_relocate_symtab (unsigned int pid)
int ldisize = arch64 ? sizeof (ldi->l64) : sizeof (ldi->l32);
int size;
- if (ptid_equal (inferior_ptid, null_ptid))
+ /* Nothing to do if we are debugging a core file. */
+ if (!target_has_execution)
return;
do
next reply other threads:[~2009-03-15 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 20:37 Joel Brobecker [this message]
2009-03-15 21:18 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315203320.GB9576@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox