From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20194 invoked by alias); 15 Mar 2009 20:38:40 -0000 Received: (qmail 20186 invoked by uid 22791); 15 Mar 2009 20:38:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Mar 2009 20:38:35 +0000 Received: (qmail 16298 invoked from network); 15 Mar 2009 20:38:33 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Mar 2009 20:38:33 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit/AIX] Fix error happening while loading a core file Date: Sun, 15 Mar 2009 21:18:00 -0000 User-Agent: KMail/1.9.10 Cc: Joel Brobecker References: <20090315203320.GB9576@adacore.com> In-Reply-To: <20090315203320.GB9576@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903152028.54485.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00245.txt.bz2 On Sunday 15 March 2009 20:33:20, Joel Brobecker wrote: > This is another regression that I noticed on AIX. > > The problem is that we had a check in xcoff_relocate_symtab that > was supposed to detect the case where we're debugging a core file. > The check was based on the inferior ptid being null. I see, no multi-threaded/lwps core files on aix then, as otherwise this would have already been noticed before. > I replaced it > with a check against target_has_execution, which seemed more > appropriate. > > Is there a routine that performs this check? Nope, that's what we've got. We'll have to do something about these target_has_* for multi-process, but meanwhile, that's indeed the correct test. -- Pedro Alves