From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6614 invoked by alias); 13 Mar 2009 23:00:50 -0000 Received: (qmail 6602 invoked by uid 22791); 13 Mar 2009 23:00:46 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Mar 2009 23:00:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BB4062C97BD; Fri, 13 Mar 2009 19:00:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B5Npim8gpNMi; Fri, 13 Mar 2009 19:00:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2E5992C97B5; Fri, 13 Mar 2009 19:00:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B6B21F5C8D; Fri, 13 Mar 2009 16:00:33 -0700 (PDT) Date: Fri, 13 Mar 2009 23:11:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix a racy FAIL on gdb.base/multi-forks.exp Message-ID: <20090313230033.GB30693@adacore.com> References: <20090313152723.GA13673@host0.dyn.jankratochvil.net> <20090313161423.GF8368@adacore.com> <20090313194932.GA5597@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090313194932.GA5597@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00218.txt.bz2 > gdb/testsuite/ > 2009-03-13 Jan Kratochvil > > Fix a racy FAIL. > * gdb.base/multi-forks.exp (continue_to_exit_bp_loc): New function with > code from `follow parent, print pids'. > (`follow child, print pids', `follow parent, print pids'): Call it. > Replace `gdb_test "break..."' by gdb_breakpoint. This seems pretty reasonable to me... > +# Continue till where $exit_bp_loc points at eating all the inferior output > +# which could otherwise corrupt our later communication with GDB. I am so sorry to be picking on your comments. I very much appreciate the fact that you spend the time writing them, especially since most people tend to not write comments. In this case, this comments also sounds strange. Here is a suggestion: # Insert a breakpoint at the location provided by the exit_bp_loc global # and resume the execution until hitting that breakpoint. We also make # sure to consume all the expected output from all processes as well, # to make sure it doesn't cause trouble during a subsequent test. -- Joel