From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6186 invoked by alias); 13 Mar 2009 22:47:09 -0000 Received: (qmail 6176 invoked by uid 22791); 13 Mar 2009 22:47:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Mar 2009 22:47:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 36ABF2C9721; Fri, 13 Mar 2009 18:47:00 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LZvKDjddoMVi; Fri, 13 Mar 2009 18:47:00 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6974A2C972A; Fri, 13 Mar 2009 18:46:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8B263F5C8D; Fri, 13 Mar 2009 15:46:53 -0700 (PDT) Date: Fri, 13 Mar 2009 23:00:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Tom Tromey , Mark Kettenis , drow@false.org, gdb-patches@sourceware.org Subject: Re: [patch] Fix `return' of long/long-long results with no debuginfo Message-ID: <20090313224653.GA30693@adacore.com> References: <20090211225012.GA28683@host0.dyn.jankratochvil.net> <200903042129.n24LTUKa000770@brahms.sibelius.xs4all.nl> <20090309015510.GA28986@host0.dyn.jankratochvil.net> <200903092233.n29MXEfG019900@brahms.sibelius.xs4all.nl> <20090311163024.GA25708@adacore.com> <20090311205901.GB25708@adacore.com> <20090313171134.GA4396@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090313171134.GA4396@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00217.txt.bz2 > 2009-03-13 Jan Kratochvil > > * stack.c (return_command ): New variables retval_expr > and old_chain. Inline parse_and_eval to initialize retval_expr. Check > RETVAL_EXPR for UNOP_CAST and set RETURN_TYPE to the RETURN_VALUE type > if RETURN_TYPE is NULL. This part looks good to me. > gdb/testsuite/ > 2009-03-13 Jan Kratochvil > > * gdb.base/return-nodebug.exp, gdb.base/return-nodebug.S: New. This part looks good to me too. Just a couple of things: - The name of the C file has a small typo in the extension.... - A comment seems malformed: > + # Test return from a function with no debug info (symbol; still it may > + # have a minimal-symbol) if it does not crash. The part in between parens sound strange. I can suggest: # Verify that we do not crash when using "return" from a function # with no debugging info (it may still have an associated minimal # symbol). I'm not sure that the side note about having minimal symbols is really necessary, though, but it's definitely not harmful in this case... (thanks for teaching me about "prepare_for_testing" ;-) -- Joel