On Tuesday 10 March 2009 00:22:30 Daniel Jacobowitz wrote:
> On Tue, Mar 10, 2009 at 12:15:03AM +0300, Vladimir Prus wrote:
> > *This* patch.
>
> You must've been working on programs in some Other Real Language
> lately... :-)

'Tis true.


>
> > @@ -97,6 +97,8 @@ static void timestamp (struct mi_timestamp *tv);
> >
> >  static void print_diff_now (struct mi_timestamp *start);
> >  static void print_diff (struct mi_timestamp *start, struct mi_timestamp
> > *end); +void print_timing_maybe ();
> > +
> >
> >  void
> >  mi_cmd_gdb_exit (char *command, char **argv, int argc)
>
> Prototypes in .h files only please.
>
> > @@ -1567,6 +1561,15 @@ print_diff_now (struct mi_timestamp *start)
> >      print_diff (start, &now);
> >    }
> >
> > +void
> > +print_timing_maybe ()
>
> (void)
>
> > +{
> > +  // If the command is -enable-timing then do_timings may be
> > +  // true whilst current_command_ts is not initialized.
>
> /* */
>
> > +void print_timing_maybe ();
>
> (void)
>
> Also, since this is public, please give it an "mi_" prefix.
>
> I have nothing useful to say about the important part of the patch,
> though.

OK :-) Here's a revised patch, just in case.

- Volodya